refactor(configuration): Remove custom VersionStrategies parsing

Leverage SharpYaml's native deserialization for enum arrays, simplifying configuration and enforcing standard YAML array format for strategies.

Author: arturcic

src/GitVersion.App.Tests/ArgumentParserTests.cs

@@ -530,13 +530,6 @@ private static IEnumerable<TestCaseData> OverrideConfigWithSingleOptionTestData(
                 UpdateBuildNumber = true
             }
         );
-        yield return new TestCaseData(
-            "strategies=[\"None\",\"Mainline\"]",
-            new GitVersionConfiguration
-            {
-                VersionStrategies = [VersionStrategies.None, VersionStrategies.Mainline]
-            }
-        );
     }
 
     [TestCaseSource(nameof(OverrideConfigWithMultipleOptionsTestData))]

src/GitVersion.Configuration.Tests/Configuration/IgnoreConfigurationTests.cs

@@ -74,9 +74,9 @@ public void WhenBadDateFormatShouldFail()
     }
 
     [Test]
-    public void ShouldSupportScalarVersionStrategiesOverrideFormat()
+    public void ShouldSupportArrayVersionStrategiesFormat()
     {
-        const string yaml = "strategies: ConfiguredNextVersion, TaggedCommit";
+        const string yaml = "strategies: [ConfiguredNextVersion, TaggedCommit]";
 
         var configuration = serializer.ReadConfiguration(yaml);
 

src/GitVersion.Configuration/ConfigurationHelper.cs

@@ -56,15 +56,6 @@ private static void Merge(IDictionary<object, object?> dictionary, IReadOnlyDict
                             Merge(anotherDictionaryValue, dictionaryValue);
                         }
 
-                        break;
-                    }
-                case IList:
-                    {
-                        if (anotherDictionary.TryGetValue(item.Key, out var value))
-                        {
-                            dictionary[item.Key] = value;
-                        }
-
                         break;
                     }
                 default:
@@ -90,15 +81,6 @@ private static void Merge(IDictionary<object, object?> dictionary, IReadOnlyDict
                         Dictionary<object, object?> anotherDictionaryValue = [];
                         Merge(anotherDictionaryValue, dictionaryValue);
                         dictionary.Add(item.Key, anotherDictionaryValue);
-                        break;
-                    }
-                case IList:
-                    {
-                        if (!dictionary.ContainsKey(item.Key))
-                        {
-                            dictionary.Add(item.Key, item.Value);
-                        }
-
                         break;
                     }
                 default:

src/GitVersion.Configuration/ConfigurationSerializer.cs

@@ -10,7 +10,6 @@ internal class ConfigurationSerializer : IConfigurationSerializer
     {
         PropertyNamingPolicy = HyphenatedJsonNamingPolicy.Instance,
         DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull,
-        Converters = [VersionStrategiesConverter.Instance]
     };
 
     public T Deserialize<T>(string input)
@@ -27,13 +26,8 @@ public T Deserialize<T>(string input)
             {
                 return (T)(object)YamlSerializer.Deserialize<GitVersionConfiguration>(input, GeneratedContext)!;
             }
-            catch (Exception exception)
+            catch (Exception exception) when (exception is not YamlException)
             {
-                if (exception is YamlException)
-                {
-                    throw;
-                }
-
                 throw new YamlException(exception.Message, exception);
             }
         }

src/GitVersion.Configuration/ConfigurationYamlContext.cs

@@ -3,9 +3,7 @@
 
 namespace GitVersion.Configuration;
 
-[YamlSourceGenerationOptions(
-    DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull,
-    Converters = [typeof(VersionStrategiesConverter)])]
+[YamlSourceGenerationOptions(DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull )]
 [YamlSerializable(typeof(GitVersionConfiguration))]
 [YamlSerializable(typeof(BranchConfiguration))]
 [YamlSerializable(typeof(PreventIncrementConfiguration))]