Upgrade to dotnet10#4741
Merged
Merged
Conversation
Updates the latest .NET LTS version to 10.0. Includes .NET 8.0 in the supported versions array. Sets the latest Docker distribution to Ubuntu 24.04.
updates the target framework moniker to .net 10.0 for all build configurations.
updates the target framework to net10.0 for the cli.
adds net10.0 as a target framework to msbuild.
arturcic
force-pushed
the
feature/dotnet10
branch
from
25840d1 to
4d8395d
Compare
Renames `TagPrefix` to `TagPrefixPattern` for clarity.
Refactors the `ReferenceNameExtensions` to use extension methods for improved code organization.
arturcic
force-pushed
the
feature/dotnet10
branch
2 times, most recently
from
bf5338c to
bfb002a
Compare
updates test project to target .net 10.
arturcic
force-pushed
the
feature/dotnet10
branch
from
bfb002a to
a0f246d
Compare
arturcic
force-pushed
the
feature/dotnet10
branch
from
ea76257 to
3880373
Compare
suppresses S4136 in multiple projects to avoid noisy warnings related to method overloads.
arturcic
force-pushed
the
feature/dotnet10
branch
from
3880373 to
038e3ec
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to support .NET 10.0, featuring a major refactoring to adopt C# extension syntax (expected in a future C# version). The changes include:
- Adds .NET 10.0 target framework support alongside .NET 8.0 and .NET 9.0
- Refactors traditional extension methods to use new
extension()syntax - Renames
TagPrefixproperty toTagPrefixPatternfor consistency - Adds
IsMergeCommitproperty toICommitinterface, replacing extension method - Updates test infrastructure and build configurations for .NET 10.0
- Reorganizes test files (splits InputSanitizerTests into separate files)
Reviewed Changes
Copilot reviewed 133 out of 133 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Directory.Build.props | Adds net10.0 target framework and suppresses nullable warnings |
| src/GitVersion.Core/Git/ICommit.cs | Adds IsMergeCommit property to interface |
| src/GitVersion.Core/Extensions/*.cs | Converts extension methods to new extension() syntax |
| src/GitVersion.Core/Configuration/EffectiveConfiguration.cs | Renames TagPrefix to TagPrefixPattern |
| new-cli/GitVersion.Cli.Generator.Tests/Extensions.cs | Creates Net10 reference assemblies helper |
| build/.run/*.xml | Updates run configurations to net10.0 |
| tests/scripts/test-msbuild-task.sh | Updates comment with net10.0 |
Comments suppressed due to low confidence (1)
src/GitVersion.Core/VersionCalculation/VersionSearchStrategies/VersionInBranchNameVersionStrategy.cs:58
- This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
arturcic
force-pushed
the
feature/dotnet10
branch
from
03d3de6 to
17466d8
Compare
3 tasks
Contributor
|
Thank you @arturcic for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the target framework version for all build and run configuration files in the
build/.rundirectory from.NET 9.0to.NET 10.0. This change ensures that all build, test, and deployment processes use the latest .NET runtime.