test: use FakeRepository for dynamic-repo cache tests#5003
Draft
arturcic wants to merge 1 commit into
Draft
Conversation
Replace the heavy https://github.com/GitTools/GitVersion.git clone target in GitVersionExecutorTests with the small, stable GitTools/FakeRepository, and hoist the URL and branch into single TargetUrl/TargetBranch constants. Cuts the suite's two slowest tests (CacheKeySameAfterReNormalizing ~115s, CacheKeyForWorktree ~66s) so GitVersionExecutorTests drops from ~184s to ~4s, and removes the flaky dependency on cloning the full GitVersion repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local timing of
GitVersion.Core.Tests(net10.0) showed the suite's two slowest tests by far live inGitVersionExecutorTests:CacheKeySameAfterReNormalizing— ~115sCacheKeyForWorktree— ~66sBoth set
TargetUrl = https://github.com/GitTools/GitVersion.gitand callpreparer.Prepare(), which clones the entire GitVersion repo over the network (twice, in the re-normalizing test). That's ~180s of network-bound work and a flaky external dependency on the size/availability of the main repo.Change
Point the dynamic-repository cache tests at the small, stable
GitTools/FakeRepositoryinstead, and hoist the URL and branch into singleTargetUrl/TargetBranchconstants (FakeRepository's default branch ismaster, notmain).DynamicRepositoryTestsis left untouched — it asserts GitVersion-specific versions and must keep cloning the real repo.Result
GitVersionExecutorTests: ~184s → ~4s (23 tests, all passing on net10.0), with the network/flakiness removed. Behaviour is unchanged — the tests only assert cache-key stability / non-emptiness, which is repo-agnostic.Build 0/0,
dotnet formatclean.🤖 Generated with Claude Code