Merge pull request #2648 from GitoxideLabs/investigate-git-dir-panic

fix: avoid GIT_DIR environment discovery panic

Author: Byron

gix/src/open/repository.rs

@@ -153,6 +153,7 @@ impl ThreadSafeRepository {
 
         let git_dir_trust = gix_sec::Trust::from_path_ownership(&git_dir)?;
         let mut options = trust_map.into_value_by_level(git_dir_trust);
+        options.git_dir_trust = git_dir_trust.into();
         options.current_dir = Some(cwd);
         ThreadSafeRepository::open_from_paths(git_dir, worktree_dir, options)
     }

gix/tests/gix/repository/open.rs

@@ -10,6 +10,32 @@ fn open_permissions_is_isolated() {
     assert!(!gix::open::Permissions::all().is_isolated());
 }
 
+#[test]
+#[serial_test::serial]
+fn discover_with_git_dir_environment_override_sets_trust() -> crate::Result {
+    let tmp = gix_testtools::tempfile::TempDir::new()?;
+    let initialized = gix::init(tmp.path())?;
+    let _env = gix_testtools::Env::new()
+        .unset("GIT_WORK_TREE")
+        .set("GIT_DIR", initialized.git_dir().to_string_lossy().into_owned());
+
+    let repo = gix::ThreadSafeRepository::discover_with_environment_overrides_opts(
+        tmp.path(),
+        Default::default(),
+        gix_sec::trust::Mapping {
+            full: crate::restricted(),
+            reduced: crate::restricted(),
+        },
+    )?;
+
+    assert_eq!(
+        repo.git_dir(),
+        initialized.git_dir(),
+        "the git-dir from the environment opens without panicking on missing trust"
+    );
+    Ok(())
+}
+
 #[test]
 fn on_root_with_decomposed_unicode() -> crate::Result {
     let tmp = gix_testtools::tempfile::TempDir::new()?;