Merge pull request #2445 from GitoxideLabs/improvements

Add `cargo machete` CI job including exclusions

Author: Byron

.github/workflows/ci.yml

@@ -470,7 +470,11 @@ jobs:
           rustup update stable
           rustup default stable
           rustup component add clippy rustfmt
+      - name: Install cargo machete
+        run: cargo install cargo-machete --version 0.9.1 --locked
       - uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3.0.0
+      - name: Run cargo machete
+        run: cargo machete
       - name: Run cargo clippy
         run: just clippy -D warnings -A unknown-lints --no-deps
       - name: Run cargo doc

Cargo.toml

@@ -304,6 +304,14 @@ members = [
 [package.metadata.docs.rs]
 features = ["document-features", "max"]
 
+[package.metadata.cargo-machete]
+ignored = [
+    # Feature-only dependency selected through `prodash-render-line-crossterm` wiring.
+    "crosstermion",
+    # Pinned direct dependency to avoid precompiled binaries; intentionally not referenced in code.
+    "serde_derive",
+]
+
 [package.metadata.binstall]
 pkg-url = "{ repo }/releases/download/v{ version }/gitoxide-max-pure-v{ version }-{ target }{ archive-suffix }"
 bin-dir = "gitoxide-max-pure-v{ version }-{ target }/{ bin }{ binary-ext }"

gitoxide-core/Cargo.toml

@@ -97,3 +97,33 @@ document-features = { version = "0.2.0", optional = true }
 
 [package.metadata.docs.rs]
 features = ["document-features", "blocking-client", "organize", "estimate-hours", "serde"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Enabled through `async-client` feature wiring only.
+    "async-io",
+    # Enabled through `async-client` feature wiring only.
+    "async-net",
+    # Enabled through `async-client` feature wiring only.
+    "async-trait",
+    # Enabled through `async-client` feature wiring only.
+    "blocking",
+    # Enabled through `estimate-hours` feature wiring only.
+    "fs-err",
+    # Enabled through `async-client` feature wiring only.
+    "futures-io",
+    # Enabled through `async-client` feature wiring only.
+    "futures-lite",
+    # Configuration-only dependency selected by the `archive` feature.
+    "gix-archive-for-configuration-only",
+    # Configuration-only dependency used to constrain global `gix-error` feature resolution.
+    "gix-error-for-configuration-only",
+    # Configuration-only dependency used to constrain global `gix-pack` feature resolution.
+    "gix-pack-for-configuration-only",
+    # Configuration-only dependency selected by `async-client` feature wiring.
+    "gix-transport-configuration-only",
+    # Imported as crate `layout`, which does not match the package name `layout-rs`.
+    "layout-rs",
+    # Enabled through `estimate-hours` feature wiring only.
+    "smallvec",
+]

gix-commitgraph/Cargo.toml

@@ -39,3 +39,9 @@ gix-hash = { path = "../gix-hash", features = ["sha256"] }
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Needed for `bstr/serde` feature forwarding, even though no direct `bstr` paths are referenced.
+    "bstr",
+]

gix-commitgraph/fuzz/Cargo.toml

@@ -7,6 +7,12 @@ edition = "2021"
 [package.metadata]
 cargo-fuzz = true
 
+[package.metadata.cargo-machete]
+ignored = [
+    # Kept for fuzz-input modeling support in this fuzz package.
+    "arbitrary",
+]
+
 [dependencies]
 anyhow = "1.0.76"
 arbitrary = { version = "1.3.2", features = ["derive"] }

gix-config/Cargo.toml

@@ -47,3 +47,9 @@ path = "./benches/large_config_file.rs"
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Public optional `serde` feature is retained for downstream feature compatibility.
+    "serde",
+]

gix-credentials/Cargo.toml

@@ -44,3 +44,9 @@ gix-testtools = { path = "../tests/tools" }
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Public optional `serde` feature is retained for downstream feature compatibility.
+    "serde",
+]

gix-diff/Cargo.toml

@@ -75,3 +75,11 @@ imara-diff-v2 = { version = "0.2.0", package = "imara-diff" }
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # WASM support dependency activated through the `wasm = ["dep:getrandom"]` feature.
+    "getrandom",
+    # Optional API feature wiring (`dep:serde`) referenced only from feature definitions.
+    "serde",
+]

gix-ignore/Cargo.toml

@@ -36,3 +36,9 @@ gix-fs = { path = "../gix-fs" }
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Public optional `serde` feature is retained for downstream feature compatibility.
+    "serde",
+]

gix-merge/Cargo.toml

@@ -52,3 +52,11 @@ pretty_assertions = "1.4.0"
 [package.metadata.docs.rs]
 all-features = true
 features = ["document-features"]
+
+[package.metadata.cargo-machete]
+ignored = [
+    # Doc-only macro dependency used under `all(doc, feature = "document-features")`.
+    "document-features",
+    # Optional `serde` feature is retained for downstream API compatibility.
+    "serde",
+]