Skip to content

fix(pinch): stop native-stack overflow on rapid pinch under Reanimated 4 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssahil97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pinch): stop native-stack overflow on rapid pinch under Reanimated 4 #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/commons/hooks/usePinchCommons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,18 @@ export const usePinchCommons = (options: PinchOptions) => {
});

gestureEnd.value = withTiming(toValue, undefined, (finished) => {
gestureEnd.value = 0;
if (finished && userCallbacks.onGestureEnd !== undefined) {
scheduleOnRN(userCallbacks.onGestureEnd);
// Only re-arm the gimmick on a genuine finish. Writing gestureEnd.value
// unconditionally here re-enters this callback via Reanimated 4.x's
// valueSetter (it fires a still-live animation's callback(false) before
// clearing _animation when the value is overwritten), recursing to a
// native-stack overflow on rapid pinch in/out. Gating on `finished`
// mirrors usePanCommons (which never self-writes) and keeps the callback
// re-entry a single no-op level deep. See issue #126.
if (finished) {
gestureEnd.value = 0;
if (userCallbacks.onGestureEnd !== undefined) {
scheduleOnRN(userCallbacks.onGestureEnd);
}
}
});
};
Expand Down