Skip to content

Commit 5ce4947

Browse files
[ci] mergify: accept [skill]/[skills] and [infra] PR title tags (hao-ai-lab#1309)
1 parent 323d74c commit 5ce4947

3 files changed

Lines changed: 32 additions & 9 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
PR TITLE: Must start with a type tag, e.g.:
33
[feat] Add new model [bugfix] Fix VAE tiling [refactor] Restructure pipeline
44
[perf] Optimize kernel [ci] Update tests [docs] Add guide
5-
[misc] Cleanup configs [new-model] Port Flux2
5+
[misc] Cleanup configs [new-model] Port Flux2 [infra] Add trace hooks
6+
[skill] Add agent skill
67
78
MERGE WORKFLOW:
89
1. Ensure pre-commit passes and you have at least 1 approval

.github/mergify.yml

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ merge_protections:
33
if:
44
- base = main
55
success_conditions:
6-
- "title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model)\\]"
6+
- "title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\\]"
77
- "#approved-reviews-by>=1"
88
- check-success~=pre-commit
99
- check-success=fastcheck-passed
@@ -79,6 +79,22 @@ pull_request_rules:
7979
label:
8080
add: ["type: new-model"]
8181

82+
- name: "label type: infra"
83+
conditions:
84+
- "title~=(?i)^\\[infra\\]"
85+
- -closed
86+
actions:
87+
label:
88+
add: ["type: infra"]
89+
90+
- name: "label type: skill"
91+
conditions:
92+
- "title~=(?i)^\\[skills?\\]"
93+
- -closed
94+
actions:
95+
label:
96+
add: ["type: skill"]
97+
8298
# ============================================================
8399
# Scope labels (from changed files)
84100
# ============================================================
@@ -262,7 +278,7 @@ pull_request_rules:
262278
- name: auto-merge when ready and all checks pass
263279
conditions:
264280
- label=ready
265-
- "title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model)\\]"
281+
- "title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\\]"
266282
- "#approved-reviews-by>=1"
267283
- check-success~=pre-commit
268284
- check-success=fastcheck-passed
@@ -292,7 +308,7 @@ pull_request_rules:
292308
conditions:
293309
- -closed
294310
- -draft
295-
- "-title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model)\\]"
311+
- "-title~=(?i)^\\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\\]"
296312
actions:
297313
comment:
298314
message: |
@@ -304,11 +320,13 @@ pull_request_rules:
304320
- `[refactor] Restructure training pipeline`
305321
- `[perf] Optimize attention kernel`
306322
- `[ci] Update test infrastructure`
323+
- `[infra] Add activation trace hooks`
307324
- `[docs] Add inference guide`
308325
- `[misc] Clean up configs`
309326
- `[new-model] Port Flux2 to FastVideo`
327+
- `[skill] Add add-model agent skill`
310328
311-
Valid tags: `feat`, `feature`, `bugfix`, `fix`, `refactor`, `perf`, `ci`, `doc`, `docs`, `misc`, `chore`, `kernel`, `new-model`
329+
Valid tags: `feat`, `feature`, `bugfix`, `fix`, `refactor`, `perf`, `ci`, `infra`, `doc`, `docs`, `misc`, `chore`, `kernel`, `new-model`, `skill`, `skills`
312330
313331
Please update your PR title and the merge protection check will pass automatically.
314332

docs/contributing/pull_requests.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ Mergify before any merge is allowed.
2525
| `[refactor]` | Code restructuring with no behavior change |
2626
| `[perf]` | Performance improvement |
2727
| `[ci]` | CI/CD or build tooling changes |
28+
| `[infra]` | Repo infrastructure: agent tooling, debug hooks, conversion scripts, dev infra |
2829
| `[doc]` or `[docs]` | Documentation only |
2930
| `[misc]` or `[chore]` | Housekeeping, dependency bumps, minor cleanup |
3031
| `[kernel]` | CUDA kernel changes in `fastvideo-kernel/` |
3132
| `[new-model]` | Adding a new model or pipeline |
33+
| `[skill]` or `[skills]` | Agent skills under `.agents/skills/` or `.claude/skills/` |
3234

3335
**Examples:**
3436

@@ -38,6 +40,8 @@ Mergify before any merge is allowed.
3840
[refactor] Restructure distributed attention dispatch
3941
[docs] Add LoRA finetuning guide
4042
[new-model] Port HunyuanVideo 1.5 to FastVideo
43+
[infra] Add activation trace hooks for pipeline debugging
44+
[skill] Add add-model agent skill
4145
```
4246

4347
If your title is missing the tag, Mergify will post a comment listing the valid formats.
@@ -51,8 +55,8 @@ Labels are applied automatically based on your PR title and the files you change
5155
need to set them manually.
5256

5357
**Type label** — set from the `[tag]` in your title:
54-
`type: feat`, `type: bugfix`, `type: refactor`, `type: perf`, `type: ci`, `type: docs`,
55-
`type: misc`, `type: new-model`
58+
`type: feat`, `type: bugfix`, `type: refactor`, `type: perf`, `type: ci`, `type: infra`,
59+
`type: docs`, `type: misc`, `type: new-model`, `type: skill`
5660

5761
**Scope labels** — set from which files you modified (multiple labels can apply):
5862
`scope: training`, `scope: inference`, `scope: attention`, `scope: kernel`, `scope: data`,
@@ -187,8 +191,8 @@ Common quick fixes:
187191
Update your title to start with a valid type tag. The Mergify merge protection check
188192
re-evaluates automatically after you save the title.
189193

190-
Valid tags: `feat`, `feature`, `bugfix`, `fix`, `refactor`, `perf`, `ci`, `doc`, `docs`,
191-
`misc`, `chore`, `kernel`, `new-model`
194+
Valid tags: `feat`, `feature`, `bugfix`, `fix`, `refactor`, `perf`, `ci`, `infra`, `doc`,
195+
`docs`, `misc`, `chore`, `kernel`, `new-model`, `skill`, `skills`
192196

193197
### My PR has merge conflicts (`needs-rebase` label)
194198

0 commit comments

Comments
 (0)