[gobby-cli-#961] fix: stable Windows file-identity in gwiki log dedup

gwiki's windows-msvc release legs failed to compile: log::same_file_identity
used std::os::windows::fs::MetadataExt::{file_index_high, file_index_low,
volume_serial_number}, which sit behind the unstable `windows_by_handle`
feature and do not exist on stable rustc (E0599/E0658). gwiki has never
shipped Windows binaries — the windows-msvc targets were added to the matrix
but the code was never stable-Windows-clean.

Read the same volume-serial + file-index identity off the open file handle
via GetFileInformationByHandle (windows-sys), preserving same_file_identity
semantics (two paths are the same file iff equal (volume serial, file index
high, file index low)). Promote windows-sys from a cfg(windows) dev-dependency
to a real cfg(windows) dependency and add the Win32_Foundation feature for
HANDLE.

Host-validated: cargo build/clippy -p gobby-wiki, cargo fmt --all --check, and
the log dedup tests pass. The windows-msvc compile is validated via the
release-gwiki.yml workflow_dispatch dry-run (cannot cross-build Windows
openssl/pdfium on macOS).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: joshwilhelmi

CHANGELOG.md

@@ -96,6 +96,12 @@ follow-up indexing fixes.
   UTF-8 char boundary before the scoped link id is computed, so transcript links
   longer than the 8191-byte Postgres btree row limit no longer fail indexing
   atomically and strand orphan vault files (#939).
+- **Windows build** — `gwiki` now compiles on `x86_64-pc-windows-msvc` /
+  `aarch64-pc-windows-msvc`. The log de-duplication path read a file's
+  volume-serial + file-index identity through the unstable `windows_by_handle`
+  std accessors (nightly-only); it now reads the same fields via the stable
+  `GetFileInformationByHandle` Win32 API, so the windows-msvc release legs build
+  and `gwiki` ships Windows binaries for the first time (#961).
 
 ## [0.6.2] — ghook — 2026-06-26
 

crates/gwiki/Cargo.toml

@@ -64,10 +64,11 @@ zip = { version = "4", default-features = false, features = ["deflate"], optiona
 [target.'cfg(unix)'.dependencies]
 libc = "0.2"
 
+[target.'cfg(windows)'.dependencies]
+# Win32 file-identity in log.rs (GetFileInformationByHandle) plus symlink handling
+# in compile::tests::compile_rejects_target_page_through_symlinked_parent.
+windows-sys = { version = "0.61", features = ["Win32_Foundation", "Win32_Storage_FileSystem"] }
+
 [dev-dependencies]
 gobby-core = { path = "../gcore", version = "0.6.1", features = ["postgres", "falkor", "qdrant", "indexing", "search", "graph-analytics", "ai"] }
 serial_test = "3"
-
-[target.'cfg(windows)'.dev-dependencies]
-# Reserved for Windows symlink handling in compile::tests::compile_rejects_target_page_through_symlinked_parent.
-windows-sys = { version = "0.61", features = ["Win32_Storage_FileSystem"] }

crates/gwiki/src/log.rs

@@ -128,18 +128,33 @@ fn same_file_identity(left: &Path, right: &Path) -> bool {
 }
 
 #[cfg(windows)]
+#[allow(dead_code, reason = "reserved gwiki CLI/API split")]
 fn same_file_identity(left: &Path, right: &Path) -> bool {
-    use std::os::windows::fs::MetadataExt;
+    use std::os::windows::io::AsRawHandle;
+    use windows_sys::Win32::Foundation::HANDLE;
+    use windows_sys::Win32::Storage::FileSystem::{
+        BY_HANDLE_FILE_INFORMATION, GetFileInformationByHandle,
+    };
 
     fn identity(path: &Path) -> Option<(u32, u32, u32)> {
-        let metadata = std::fs::metadata(path).ok()?;
-        if metadata.file_index_high() == 0 && metadata.file_index_low() == 0 {
+        // The std MetadataExt accessors for volume serial + file index are still
+        // unstable (windows_by_handle), so read them off the open file handle
+        // via GetFileInformationByHandle to stay on stable Rust.
+        let file = std::fs::File::open(path).ok()?;
+        let mut info: BY_HANDLE_FILE_INFORMATION = unsafe { std::mem::zeroed() };
+        // SAFETY: `file` owns a valid handle for the duration of the call, and
+        // `info` is a properly aligned, writable output buffer.
+        let ok = unsafe { GetFileInformationByHandle(file.as_raw_handle() as HANDLE, &mut info) };
+        if ok == 0 {
+            return None;
+        }
+        if info.nFileIndexHigh == 0 && info.nFileIndexLow == 0 {
             return None;
         }
         Some((
-            metadata.volume_serial_number(),
-            metadata.file_index_high(),
-            metadata.file_index_low(),
+            info.dwVolumeSerialNumber,
+            info.nFileIndexHigh,
+            info.nFileIndexLow,
         ))
     }