[project-#176] Remove search --path compatibility

Author: joshwilhelmi

CHANGELOG.md

@@ -13,10 +13,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 #### gcode
 
-- **Positional search paths** — `gcode search`, `gcode search-text`, and
-  `gcode search-content` now accept one or more positional path filters after
-  the query. Bare paths match exact files and descendants; glob paths stay
-  verbatim; multiple paths use OR semantics.
+- **Positional search paths** — `gcode search`, `gcode search-symbol`,
+  `gcode search-text`, and `gcode search-content` now accept one or more
+  positional path filters after the query. Bare paths match exact files and
+  descendants; glob paths stay verbatim; multiple paths use OR semantics.
+
+### Removed
+
+#### gcode
+
+- **`--path` search filters** — breaking CLI cleanup: `gcode search`,
+  `gcode search-symbol`, `gcode search-text`, and `gcode search-content` no
+  longer accept `--path <glob>`. Pass paths and globs positionally after the
+  query instead.
 
 
 ## [0.8.4] — gcode

crates/gcode/README.md

@@ -123,6 +123,7 @@ gcode search "query" --language rust      # Filter by source language
 gcode search "query" src/**/*.rs          # Filter by path or glob
 gcode search-symbol "outline"             # Exact-first symbol/command lookup
 gcode search-symbol "outline" --kind function --language rust
+gcode search-symbol "Context" crates/gcode/src
 gcode search-text "query"                 # BM25 on symbol names/signatures
 gcode search-text "query" crates/gcode/src
 gcode search-content "query"              # BM25 on file content, comments, config, CSS

crates/gcode/assets/SKILL.md

@@ -14,11 +14,11 @@ This project is indexed. Use `gcode` via Bash for fast code search and navigatio
 ## Search
 
 - `gcode search "query" [PATH ...]` — hybrid search: pg_search BM25 + semantic + graph boost (best for fuzzy or natural-language queries)
-- `gcode search-symbol "name"` — exact-first symbol lookup with deterministic ranking (use when you already know most of the name)
+- `gcode search-symbol "name" [PATH ...]` — exact-first symbol lookup with deterministic ranking (use when you already know most of the name)
 - `gcode search-text "query" [PATH ...]` — pg_search BM25 search on symbol names, signatures, and docstrings
 - `gcode search-content "query" [PATH ...]` — full-text search across file bodies (source, comments, config files, CSS, SQL)
 
-Search filters compose: `search` and `search-symbol` accept `--kind <kind>`; use `gcode kinds` to discover values. `search`, `search-text`, and `search-content` accept positional path filters after the query (paths or globs, OR semantics), plus `--language <lang>`, `--limit N`, and `--offset N` for scoped or paginated results. `search-symbol` accepts `--path <glob>` for path scoping.
+Search filters compose: `search` and `search-symbol` accept `--kind <kind>`; use `gcode kinds` to discover values. All search commands accept positional path filters after the query (paths or globs, OR semantics), plus `--language <lang>`, `--limit N`, and `--offset N` for scoped or paginated results.
 
 ## Retrieval
 

crates/gcode/src/main.rs

@@ -92,13 +92,13 @@ enum Command {
         /// Filter by source language (e.g. rust, python, css)
         #[arg(long)]
         language: Option<String>,
-        /// Filter by file path glob (e.g. "src/**/*.rs", "*.py")
-        #[arg(long)]
-        path: Option<String>,
     },
     /// Exact-first symbol/name search with deterministic ranking
     SearchSymbol {
         query: String,
+        /// Optional file paths or globs to filter results
+        #[arg(value_name = "PATH")]
+        paths: Vec<String>,
         #[arg(long, default_value = "10")]
         limit: usize,
         /// Skip first N results (for pagination)
@@ -110,9 +110,6 @@ enum Command {
         /// Filter by source language (e.g. rust, python, css)
         #[arg(long)]
         language: Option<String>,
-        /// Filter by file path glob (e.g. "src/**/*.rs", "*.py")
-        #[arg(long)]
-        path: Option<String>,
     },
     /// pg_search BM25 search on symbol metadata (names, signatures, docstrings)
     SearchText {
@@ -128,9 +125,6 @@ enum Command {
         /// Filter by source language (e.g. rust, python, css)
         #[arg(long)]
         language: Option<String>,
-        /// Filter by file path glob (e.g. "src/**/*.rs", "*.py")
-        #[arg(long)]
-        path: Option<String>,
     },
     /// pg_search BM25 search on file content chunks
     SearchContent {
@@ -146,9 +140,6 @@ enum Command {
         /// Filter by source language (e.g. rust, python, css)
         #[arg(long)]
         language: Option<String>,
-        /// Filter by file path glob (e.g. "src/**/*.rs", "*.py")
-        #[arg(long)]
-        path: Option<String>,
     },
 
     // ── Symbol Retrieval (works in all modes) ────────────────────────
@@ -238,13 +229,6 @@ fn ensure_symbol_fresh(ctx: &config::Context, disabled: bool, id: &str) -> anyho
     Ok(())
 }
 
-fn merge_paths(mut paths: Vec<String>, path: Option<String>) -> Vec<String> {
-    if let Some(path) = path {
-        paths.push(path);
-    }
-    paths
-}
-
 fn main() -> anyhow::Result<()> {
     let cli = Cli::parse();
 
@@ -290,10 +274,8 @@ fn main() -> anyhow::Result<()> {
             offset,
             kind,
             language,
-            path,
         } => {
             ensure_project_fresh(&ctx, cli.no_freshness)?;
-            let paths = merge_paths(paths, path);
             commands::search::search(
                 &ctx,
                 &query,
@@ -309,14 +291,13 @@ fn main() -> anyhow::Result<()> {
         }
         Command::SearchSymbol {
             query,
+            paths,
             limit,
             offset,
             kind,
             language,
-            path,
         } => {
             ensure_project_fresh(&ctx, cli.no_freshness)?;
-            let paths = merge_paths(Vec::new(), path);
             commands::search::search_symbol(
                 &ctx,
                 &query,
@@ -336,10 +317,8 @@ fn main() -> anyhow::Result<()> {
             limit,
             offset,
             language,
-            path,
         } => {
             ensure_project_fresh(&ctx, cli.no_freshness)?;
-            let paths = merge_paths(paths, path);
             commands::search::search_text(
                 &ctx,
                 &query,
@@ -356,10 +335,8 @@ fn main() -> anyhow::Result<()> {
             limit,
             offset,
             language,
-            path,
         } => {
             ensure_project_fresh(&ctx, cli.no_freshness)?;
-            let paths = merge_paths(paths, path);
             commands::search::search_content(
                 &ctx,
                 &query,
@@ -523,30 +500,29 @@ mod tests {
             "gcode",
             "search-symbol",
             "outline",
+            "crates/gcode/src",
             "--kind",
             "function",
             "--language",
             "rust",
-            "--path",
-            "src/**/*.rs",
         ])
         .expect("search-symbol parses");
 
         match cli.command {
             Command::SearchSymbol {
                 query,
+                paths,
                 limit,
                 offset,
                 kind,
                 language,
-                path,
             } => {
                 assert_eq!(query, "outline");
+                assert_eq!(paths, vec!["crates/gcode/src"]);
                 assert_eq!(limit, 10);
                 assert_eq!(offset, 0);
                 assert_eq!(kind.as_deref(), Some("function"));
                 assert_eq!(language.as_deref(), Some("rust"));
-                assert_eq!(path.as_deref(), Some("src/**/*.rs"));
             }
             _ => panic!("expected search-symbol command"),
         }
@@ -655,22 +631,24 @@ mod tests {
     }
 
     #[test]
-    fn test_parse_search_content_path_alias() {
-        let cli = Cli::try_parse_from([
-            "gcode",
-            "search-content",
-            "QUERY",
-            "--path",
-            "crates/ghook/**",
-        ])
-        .expect("search-content parses");
+    fn test_parse_search_path_flag_rejected() {
+        for command in ["search", "search-symbol", "search-text", "search-content"] {
+            let err = match Cli::try_parse_from([
+                "gcode",
+                command,
+                "QUERY",
+                "--path",
+                "crates/gcode/src",
+            ]) {
+                Ok(_) => panic!("--path should be rejected for {command}"),
+                Err(err) => err,
+            };
 
-        match cli.command {
-            Command::SearchContent { paths, path, .. } => {
-                assert!(paths.is_empty());
-                assert_eq!(path.as_deref(), Some("crates/ghook/**"));
-            }
-            _ => panic!("expected search-content command"),
+            assert_eq!(err.kind(), clap::error::ErrorKind::UnknownArgument);
+            assert!(
+                err.to_string().contains("--path"),
+                "unexpected error for {command}: {err}"
+            );
         }
     }
 

docs/guides/gcode-development-guide.md

@@ -274,7 +274,7 @@ Source 4: Graph Expand (FalkorDB)
   ↓ All sources → RRF merge → Symbol resolution → Positional path filters → Pagination
 ```
 
-`search`, `search-text`, and `search-content` accept positional path filters after the query. Bare paths expand to exact + subtree matches; glob paths stay verbatim; multiple paths use OR semantics. BM25 queries add a parenthesized SQL `LIKE` prefix OR block only when every expanded pattern has a safe prefix. Rust `glob::Pattern` post-filtering then enforces exact semantics across all sources, including semantic/graph results that lack SQL-side filtering.
+`search`, `search-symbol`, `search-text`, and `search-content` accept positional path filters after the query. Bare paths expand to exact + subtree matches; glob paths stay verbatim; multiple paths use OR semantics. BM25 queries add a parenthesized SQL `LIKE` prefix OR block only when every expanded pattern has a safe prefix. Rust `glob::Pattern` post-filtering then enforces exact semantics across all sources, including semantic/graph results that lack SQL-side filtering.
 
 ### RRF Merge (rrf.rs)
 

docs/guides/gcode-user-guide.md

@@ -116,12 +116,13 @@ the canonical hit at rank 0 instead of letting hybrid ranking rerank it.
 ```bash
 gcode search-symbol "outline"
 gcode search-symbol "Context" --kind class --language rust
-gcode search-symbol "ensure_fresh" --path "crates/gcode/**"
+gcode search-symbol "ensure_fresh" crates/gcode
+gcode search-symbol "Context" crates/gcode/src --kind class --language rust
 ```
 
 **When to use:** You know the symbol's name (or close to it) and want a stable, top-ranked match — for example, before calling `gcode symbol <id>`.
 
-**Options:** `--limit N`, `--offset N`, `--kind <kind>`, `--language <lang>`, `--path <glob>`.
+**Options:** `--limit N`, `--offset N`, `--kind <kind>`, `--language <lang>`, positional `PATH ...`.
 
 ### Text Search (`gcode search-text`)