Skip to content

Commit dd06322

Browse files
author
SuiYue-2308
committed
remove the min.primarySecondaryDistStartEnd2 from opt.discovery since this is not used in transcript discovery
1 parent 5add785 commit dd06322

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

R/bambu.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,8 @@
3434
#' annotation to be assigned to the same gene id, defaults to 10bp}
3535
#' \item{min.primarySecondaryDist}{specifying the minimum number of distance
3636
#' threshold, defaults to 5bp}
37-
#' \item{min.primarySecondaryDistStartEnd1}{specifying the minimum number
37+
#' \item{min.primarySecondaryDistStartEnd1}{specifying the minimum number
3838
#' of distance threshold, used for extending annotation, defaults to 5bp}
39-
#' \item{min.primarySecondaryDistStartEnd2}{specifying the minimum number
40-
#' of distance threshold, used for estimating distance to annotation,
41-
#' defaults to 5bp}
4239
#' \item{min.txScore.multiExon}{specifying the minimum transcript level
4340
#' threshold for multi-exon transcripts during sample combining,
4441
#' defaults to 0}
@@ -183,6 +180,8 @@ bambu <- function(reads, annotations = NULL, genome = NULL, NDR = NULL,
183180
}
184181
if(lowMemory)
185182
message("lowMemory has been deprecated and split into processByChromosome and processByBam. Please see Documentation")
183+
if(!is.null(opt.discovery[["min.primarySecondaryDistStartEnd2"]]))
184+
message("min.primarySecondaryDistStartEnd2 has been moved to opt.rcAssignment. Please pass this parameter via opt.rcAssignment instead.")
186185
if(is.null(annotations)){
187186
annotations <- GRangesList()
188187
} else {

R/bambu_utilityFunctions.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ setDiscoveryParameters <- function(discoveryParameters){
2626
min.exonOverlap = 10,
2727
min.primarySecondaryDist = 5,
2828
min.primarySecondaryDistStartEnd1 = 5, # for creating new annotations
29-
min.primarySecondaryDistStartEnd2 = 5, # for read assignment
3029
min.txScore.multiExon = 0,
3130
min.txScore.singleExon = 1,
3231
fitReadClassModel = TRUE,

0 commit comments

Comments
 (0)