Merge Devel pre v4 to sc_spatial_wrapper#573
Closed
ch99l wants to merge 11 commits intosc_spatial_wrapperfrom
Closed
Merge Devel pre v4 to sc_spatial_wrapper#573ch99l wants to merge 11 commits intosc_spatial_wrapperfrom
ch99l wants to merge 11 commits intosc_spatial_wrapperfrom
Conversation
…e `remove.subset` and `min.sampleNumber`. Now, NDR = 0.999 and NDR = 1 produce identical results except for the NDR threshold itself.
…DistStartEnd1/2 from opt.discovery into a new opt.rcAssignment parameter with its own setRcAssignmentParameters().
…econdaryDistStartEnd1/2 from opt.discovery into a new opt.rcAssignment parameter with its own setRcAssignmentParameters()." This reverts commit dac871e.
…marySecondaryDist, and min.primarySecondaryDistStartEnd2, so the assignment step can be tuned independently from opt.discovery. calculateDistTable() and assignReadClasstoTranscripts() now use rcAssignmentParameters instead of isoreParameters.
…iscoveryParameters for consistency with setRcAssignmentParameters and setEmParameters naming convention.
… this is not used in transcript discovery
fix: adjust NDR threshold behavior. Previously, NDR = 1 would overrid…
Implement opt.rcAssignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes # (issue number)
Type of Change
Description
Please provide a summary and the motivation for the changes. Why is this change necessary? What problem does it solve?
Implementation Details
Briefly describe how the changes were implemented. Which specific code segments or logic paths within the primary functional arguments (e.g.,
demultiplexed,discovery,quant) are affected? Include relevant technical details for any algorithmic changes or data structure modifications specific to Bambu.Impact of Changes
Briefly describe the impact of the implemented changes. For example:
Checklist