Skip to content

Merge Devel pre v4 to sc_spatial_wrapper#573

Closed
ch99l wants to merge 11 commits intosc_spatial_wrapperfrom
devel_pre_v4
Closed

Merge Devel pre v4 to sc_spatial_wrapper#573
ch99l wants to merge 11 commits intosc_spatial_wrapperfrom
devel_pre_v4

Conversation

@ch99l
Copy link
Copy Markdown
Collaborator

@ch99l ch99l commented Apr 20, 2026

Related Issue

Fixes # (issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (please specify if the change breaks existing functionality)
    • Non breaking change (the feature doesn't change existing functionality)
    • Breaking change (the feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance optimization

Description

Please provide a summary and the motivation for the changes. Why is this change necessary? What problem does it solve?

Implementation Details

Briefly describe how the changes were implemented. Which specific code segments or logic paths within the primary functional arguments (e.g., demultiplexed, discovery, quant) are affected? Include relevant technical details for any algorithmic changes or data structure modifications specific to Bambu.

Impact of Changes

Briefly describe the impact of the implemented changes. For example:

  • Results are identical to the previous version.
  • Bug fix only (no changes to output).
  • Adds one column to the SE object.
  • Transcript quantification results show minimal differences.

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (vignettes, man pages).
  • I have tested the code on a full dataset, and any differences have been described in the Impact of Changes section.

SuiYue-2308 and others added 11 commits April 15, 2026 14:06
…e `remove.subset` and `min.sampleNumber`. Now, NDR = 0.999 and NDR = 1 produce identical results except for the NDR threshold itself.
…DistStartEnd1/2 from opt.discovery into a new opt.rcAssignment parameter with its own setRcAssignmentParameters().
…econdaryDistStartEnd1/2 from opt.discovery into a new opt.rcAssignment parameter with its own setRcAssignmentParameters()."

This reverts commit dac871e.
…marySecondaryDist, and min.primarySecondaryDistStartEnd2, so the assignment step can be tuned independently from opt.discovery. calculateDistTable() and assignReadClasstoTranscripts() now use rcAssignmentParameters instead of isoreParameters.
…iscoveryParameters for consistency with setRcAssignmentParameters and setEmParameters naming convention.
fix: adjust NDR threshold behavior. Previously, NDR = 1 would overrid…
@ch99l ch99l closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants