Qtfred bugfix pass (scp-fs2open#7363)

Author: MjnMixael

code/missioneditor/common.cpp

@@ -25,23 +25,12 @@ SCP_string Voice_script_instructions_string = "$name - name of the message\r\n"
                                               "$note - message notes\r\n\r\n"
                                               "Note that $persona and $sender will only appear for the Message section.";
 
-// TODO: The implementation here is a direct copy of what was in the original FRED code. It is not clear whether the
-// original implementation was intentionally designed to produce the same output as the incorrect implementations in the
-// two editors, or whether it was intended to be a correct normalization but was implemented incorrectly. If the former,
-// then this implementation should be changed to produce the same output as the original implementations in the two
-// editors, even if that output is mathematically incorrect. If the latter, then this implementation should be changed
-// to produce correct normalization into [-180, 180] using a step of 360 instead of 180. This should be evaluated and
-// decided upon before making any changes to this implementation.
-
-// NOTE: FRED and QtFRED Relative coordinates used this version exactly while QtFRED Object orient editor used the
-// correct 360 step version. This version was preserved here to avoid silent behavior changes to FRED during a routine 
-// cleanup pass. This should be fixed intentionally in a dedicated pass once the impact on both editors has been evaluated.
 float normalize_degrees(float deg)
 {
 	while (deg < -180.0f)
-		deg += 180.0f; // was 360.0f in the qtfred object orient version, but this is the original FRED implementation
+		deg += 360.0f;
 	while (deg > 180.0f)
-		deg -= 180.0f; // was 360.0f in the qtfred object orient version, but this is the original FRED implementation
+		deg -= 360.0f;
 	// check for negative zero
 	if (deg == -0.0f)
 		deg = 0.0f;

qtfred/src/mission/Editor.cpp

@@ -664,7 +664,6 @@ void Editor::clearMission(bool fast_reload) {
 	// however, FRED expects to parse comments from the raw buffer, so we need a nominal string for that
 	allocate_parse_text(1);
 
-	missionLoaded("");
 }
 
 void Editor::initialSetup() {
@@ -893,6 +892,7 @@ void Editor::createNewMission() {
 	stars_post_level_init();
 	undoCount = undoAvailable = 0;
 	autosave("nothing");
+	missionLoaded("");
 }
 void Editor::hideMarkedObjects() {
 	object* ptr;

qtfred/src/mission/dialogs/WaypointEditorDialogModel.cpp

@@ -214,7 +214,10 @@ void WaypointEditorDialogModel::setCurrentlySelectedPath(int id)
 		return; // out of range; ignore
 	}
 
-	if (apply()) {
+	// Only apply if there is actually a current path to save changes to.
+	bool canProceed = (_editor->cur_waypoint_list == nullptr) || apply();
+
+	if (canProceed) {
 		_editor->unmark_all();
 
 		// mark all waypoints belonging to the selected list

qtfred/src/ui/dialogs/EventEditor/HeadAnimationPickerDialog.cpp

@@ -315,7 +315,10 @@ void HeadAnimationPickerDialog::setSelectedByName(const QString& name)
 	for (int i = 0; i < _list->count(); ++i) {
 		auto* it = _list->item(i);
 		if (it->data(Qt::UserRole).toString() == name) {
-			_list->setCurrentItem(it);
+			{
+				const QSignalBlocker blocker(_list);
+				_list->setCurrentItem(it);
+			}
 			_list->scrollToItem(it, QAbstractItemView::PositionAtCenter);
 			_previewingName = name;
 			_previewElapsedSeconds = 0.0f;