use std::move() for local variables that are copied but not reused (scp-fs2open#7308)

* use std::move() for local variables that are copied but not reused

Addresses ~140 Coverity "Variable copied when it could be moved"
defects across 74 files.  Every std::move() targets a local variable
whose value is consumed by push_back, emplace, assignment, lambda
capture, or a function call and is never read again afterward.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* clang: use std::make_shared

* clang: use std::make_unique

* address feedback

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Goober5000

code/actions/BuiltinActionDefinition.h

@@ -30,7 +30,7 @@ class BuiltinActionDefinition : public ActionDefinition {
 		// This should have been caught earlier
 		Assertion(paramIter != parameterExpressions.cend(), "Could not find built-in parameter!");
 
-		return std::unique_ptr<Action>(new TAction(paramIter->second.template asTyped<ActionValueType>()));
+		return std::make_unique<TAction>(paramIter->second.template asTyped<ActionValueType>());
 	}
 };
 

code/actions/expression/ActionExpression.cpp

@@ -24,7 +24,7 @@ ActionExpression ActionExpression::parseFromTable(ValueType expectedReturnType,
 
 	stuff_string(expressionText, F_NAME);
 
-	ExpressionParser parser(expressionText);
+	ExpressionParser parser(std::move(expressionText));
 
 	auto expression = parser.parse(context);
 
@@ -45,7 +45,7 @@ ActionExpression ActionExpression::parseFromTable(ValueType expectedReturnType,
 	}
 
 	// Everything is valid
-	return ActionExpression(expression);
+	return ActionExpression(std::move(expression));
 }
 
 Value ActionExpression::execute(const ProgramVariables& variables) const

code/actions/expression/ProgramVariables.cpp

@@ -6,7 +6,7 @@ namespace expression {
 
 ProgramVariablesDefinition& ProgramVariablesDefinition::addScope(const SCP_string& name)
 {
-	auto scope = std::unique_ptr<ProgramVariablesDefinition>(new ProgramVariablesDefinition());
+	auto scope = std::make_unique<ProgramVariablesDefinition>();
 
 	auto scopePtr = scope.get();
 

code/actions/types/MoveToSubmodel.cpp

@@ -70,7 +70,7 @@ ActionResult MoveToSubmodel::execute(ProgramLocals& locals) const
 
 std::unique_ptr<Action> MoveToSubmodel::clone() const
 {
-	return std::unique_ptr<Action>(new MoveToSubmodel(*this));
+	return std::make_unique<MoveToSubmodel>(*this);
 }
 
 } // namespace types

code/actions/types/ParticleEffectAction.cpp

@@ -61,15 +61,15 @@ ActionResult ParticleEffectAction::execute(ProgramLocals& locals) const
 	matrix orientation;
 	vm_vector_2_matrix_norm(&orientation, &direction);	// direction is normalized in SetDirectionAction::execute
 
-	source->setHost(make_unique<EffectHostObject>(locals.host.objp(), local_pos, orientation, true));
+	source->setHost(std::make_unique<EffectHostObject>(locals.host.objp(), local_pos, orientation, true));
 	source->finishCreation();
 
 	return ActionResult::Finished;
 }
 
 std::unique_ptr<Action> ParticleEffectAction::clone() const
 {
-	return std::unique_ptr<Action>(new ParticleEffectAction(*this));
+	return std::make_unique<ParticleEffectAction>(*this);
 }
 
 } // namespace types

code/actions/types/PlaySoundAction.cpp

@@ -57,7 +57,7 @@ ActionResult PlaySoundAction::execute(ProgramLocals& locals) const
 }
 std::unique_ptr<Action> PlaySoundAction::clone() const
 {
-	return std::unique_ptr<Action>(new PlaySoundAction(*this));
+	return std::make_unique<PlaySoundAction>(*this);
 }
 } // namespace types
 } // namespace actions

code/actions/types/SetDirectionAction.cpp

@@ -32,7 +32,7 @@ ActionResult SetDirectionAction::execute(ProgramLocals& locals) const
 
 std::unique_ptr<Action> SetDirectionAction::clone() const
 {
-	return std::unique_ptr<Action>(new SetDirectionAction(*this));
+	return std::make_unique<SetDirectionAction>(*this);
 }
 
 } // namespace types

code/actions/types/SetPositionAction.cpp

@@ -27,7 +27,7 @@ ActionResult SetPositionAction::execute(ProgramLocals& locals) const
 
 std::unique_ptr<Action> SetPositionAction::clone() const
 {
-	return std::unique_ptr<Action>(new SetPositionAction(*this));
+	return std::make_unique<SetPositionAction>(*this);
 }
 
 } // namespace types

code/actions/types/WaitAction.cpp

@@ -41,7 +41,7 @@ ActionResult WaitAction::execute(actions::ProgramLocals& locals) const
 }
 std::unique_ptr<Action> WaitAction::clone() const
 {
-	return std::unique_ptr<Action>(new WaitAction(*this));
+	return std::make_unique<WaitAction>(*this);
 }
 
 } // namespace types

code/ai/aiturret.cpp

@@ -2042,7 +2042,7 @@ bool turret_fire_weapon(int weapon_num,
 						}
 						//spawn particle effect
 						auto particleSource = particle::ParticleManager::get()->createSource(wip->muzzle_effect);
-						particleSource->setHost(make_unique<EffectHostTurret>(&Objects[parent_ship->objnum], turret->system_info->turret_gun_sobj, turret->turret_next_fire_pos, false));
+						particleSource->setHost(std::make_unique<EffectHostTurret>(&Objects[parent_ship->objnum], turret->system_info->turret_gun_sobj, turret->turret_next_fire_pos, false));
 						particleSource->setTriggerRadius(objp->radius * radius_mult);
 						particleSource->setTriggerVelocity(vm_vec_mag_quick(&objp->phys_info.vel));
 						particleSource->finishCreation();
@@ -2163,7 +2163,7 @@ void turret_swarm_fire_from_turret(turret_swarm_info *tsi)
 		if (Weapon_info[tsi->weapon_class].muzzle_effect.isValid()) {
 			//spawn particle effect
 			auto particleSource = particle::ParticleManager::get()->createSource(Weapon_info[tsi->weapon_class].muzzle_effect);
-			particleSource->setHost(make_unique<EffectHostTurret>(&Objects[tsi->parent_objnum], tsi->turret->system_info->turret_gun_sobj, tsi->turret->turret_next_fire_pos - 1, false));
+			particleSource->setHost(std::make_unique<EffectHostTurret>(&Objects[tsi->parent_objnum], tsi->turret->system_info->turret_gun_sobj, tsi->turret->turret_next_fire_pos - 1, false));
 			particleSource->setTriggerRadius(Objects[weapon_objnum].radius);
 			particleSource->finishCreation();
 		}