clang

Author: MjnMixael

qtfred/src/mission/dialogs/AboutDialogModel.cpp

@@ -23,7 +23,7 @@ void AboutDialogModel::reject()
 {
 }
 
-SCP_string AboutDialogModel::getVersionString() const
+SCP_string AboutDialogModel::getVersionString()
 {
 	SCP_string graphicsAPI;
 	switch (gr_screen.mode) {
@@ -44,12 +44,12 @@ SCP_string AboutDialogModel::getVersionString() const
 	return result;
 }
 
-SCP_string AboutDialogModel::getCopyrightString() const
+SCP_string AboutDialogModel::getCopyrightString()
 {
 	return "Based on FRED2_OPEN: Copyright \xc2\xa9 1999 Volition, Inc. All Rights Reserved";
 }
 
-SCP_vector<SCP_string> AboutDialogModel::getQtFREDCredits() const
+SCP_vector<SCP_string> AboutDialogModel::getQtFREDCredits()
 {
 	return {
 		"Initial Qt port by groscask",
@@ -58,7 +58,7 @@ SCP_vector<SCP_string> AboutDialogModel::getQtFREDCredits() const
 	};
 }
 
-SCP_vector<SCP_string> AboutDialogModel::getGraphicsCredits() const
+SCP_vector<SCP_string> AboutDialogModel::getGraphicsCredits()
 {
 	switch (gr_screen.mode) {
 	case GR_OPENGL:
@@ -73,12 +73,12 @@ SCP_vector<SCP_string> AboutDialogModel::getGraphicsCredits() const
 	return {};
 }
 
-SCP_string AboutDialogModel::getSCPCreditsText() const
+SCP_string AboutDialogModel::getSCPCreditsText()
 {
 	return fs2_open_credit_text;
 }
 
-SCP_string AboutDialogModel::getQuoteString() const
+SCP_string AboutDialogModel::getQuoteString()
 {
 	return "FRED2 has been deprecated. We regret nothing.";
 }

qtfred/src/mission/dialogs/AboutDialogModel.h

@@ -15,12 +15,12 @@ class AboutDialogModel : public AbstractDialogModel {
 	bool apply() override;
 	void reject() override;
 
-	SCP_string getVersionString() const;
-	SCP_string getCopyrightString() const;
-	SCP_vector<SCP_string> getQtFREDCredits() const;
-	SCP_vector<SCP_string> getGraphicsCredits() const;
-	SCP_string getSCPCreditsText() const;
-	SCP_string getQuoteString() const;
+	static SCP_string getVersionString();
+	static SCP_string getCopyrightString();
+	static SCP_vector<SCP_string> getQtFREDCredits();
+	static SCP_vector<SCP_string> getGraphicsCredits();
+	static SCP_string getSCPCreditsText();
+	static SCP_string getQuoteString();
 };
 
 } // namespace fso::fred::dialogs

qtfred/src/ui/dialogs/AboutDialog.cpp

@@ -66,17 +66,17 @@ void AboutDialog::on_scpCreditsButton_clicked()
 	dialog->show();
 }
 
-void AboutDialog::on_reportBugButton_clicked()
+void AboutDialog::on_reportBugButton_clicked() // NOLINT(readability-convert-member-functions-to-static)
 {
 	QDesktopServices::openUrl(QUrl("https://github.com/scp-fs2open/fs2open.github.com/issues", QUrl::TolerantMode));
 }
 
-void AboutDialog::on_visitForumsButton_clicked()
+void AboutDialog::on_visitForumsButton_clicked() // NOLINT(readability-convert-member-functions-to-static)
 {
 	QDesktopServices::openUrl(QUrl("https://www.hard-light.net/forums/", QUrl::TolerantMode));
 }
 
-void AboutDialog::on_aboutQtButton_clicked()
+void AboutDialog::on_aboutQtButton_clicked() // NOLINT(readability-convert-member-functions-to-static)
 {
 	QApplication::aboutQt();
 }

qtfred/src/ui/dialogs/AboutDialog.h

@@ -19,7 +19,7 @@ class AboutDialog : public QDialog {
 	explicit AboutDialog(QWidget* parent, EditorViewport* viewport);
 	~AboutDialog() override;
 
-private slots:
+private slots: // NOLINT(readability-redundant-access-specifiers)
 	void on_scpCreditsButton_clicked();
 	void on_reportBugButton_clicked();
 	void on_visitForumsButton_clicked();