misc fixes to start/loop/end snds

Author: Baezon

code/ship/ship.cpp

@@ -10790,31 +10790,35 @@ void update_firing_sounds(object* objp, ship* shipp)
 		// equality comparisons to -1 are correct here, -2 is valid and means a loop is active but the modder didnt specify an actual loop sound
 
 		if (swp->firing_loop_sounds[i] == -1 && trigger_down && !primaries_locked && selected && has_resources && burst_only_allowed && !dying) {
+			auto* pm = model_get(Ship_info[shipp->ship_info_index].model_num);
+			vec3d snd_pos, world_snd_pos;
+			vm_vec_avg_n(&snd_pos, pm->gun_banks[i].num_slots, pm->gun_banks[i].pnt);
+			vm_vec_unrotate(&world_snd_pos, &snd_pos, &objp->orient);
+			world_snd_pos += objp->pos;
+
 			if (wip->start_firing_snd.isValid() && start_snd_played != wip->start_firing_snd) {
-				if (objp == Player_obj)
-					snd_play(gamesnd_get_game_sound(wip->start_firing_snd));
-				else
-					snd_play_3d(gamesnd_get_game_sound(wip->start_firing_snd), &objp->pos, &View_position);
+				snd_play_3d(gamesnd_get_game_sound(wip->start_firing_snd), &objp->pos, &world_snd_pos);
 
 				start_snd_played = wip->start_firing_snd;
 			}
 
-			vec3d pos = model_get(Ship_info[shipp->ship_info_index].model_num)->view_positions[0].pnt;
-
 			if (wip->linked_loop_firing_snd.isValid() && shipp->flags[Ship::Ship_Flags::Primary_linked])
-				swp->firing_loop_sounds[i] = obj_snd_assign(shipp->objnum, wip->linked_loop_firing_snd, &pos, OS_PLAY_ON_PLAYER);
+				swp->firing_loop_sounds[i] = obj_snd_assign(shipp->objnum, wip->linked_loop_firing_snd, &snd_pos, OS_PLAY_ON_PLAYER);
 			else if (wip->loop_firing_snd.isValid())
-				swp->firing_loop_sounds[i] = obj_snd_assign(shipp->objnum, wip->loop_firing_snd, &pos, OS_PLAY_ON_PLAYER);
+				swp->firing_loop_sounds[i] = obj_snd_assign(shipp->objnum, wip->loop_firing_snd, &snd_pos, OS_PLAY_ON_PLAYER);
 			else
 				swp->firing_loop_sounds[i] = -2;
 		} 
 
 		if (swp->firing_loop_sounds[i] != -1 && (!trigger_down || primaries_locked || !selected || !has_resources || !burst_only_allowed || dying)) {
+			auto* pm = model_get(Ship_info[shipp->ship_info_index].model_num);
+			vec3d world_snd_pos;
+			vm_vec_avg_n(&world_snd_pos, pm->gun_banks[i].num_slots, pm->gun_banks[i].pnt);
+			vm_vec_unrotate(&world_snd_pos, &world_snd_pos, &objp->orient);
+			world_snd_pos += objp->pos;
+
 			if (wip->end_firing_snd.isValid() && end_snd_played != wip->end_firing_snd) {
-				if (objp == Player_obj)
-					snd_play(gamesnd_get_game_sound(wip->end_firing_snd));
-				else
-					snd_play_3d(gamesnd_get_game_sound(wip->end_firing_snd), &objp->pos, &View_position);
+				snd_play_3d(gamesnd_get_game_sound(wip->end_firing_snd), &objp->pos, &world_snd_pos);
 
 				end_snd_played = wip->end_firing_snd;
 			}