coverity: move instead of copy

Goober5000 · Goober5000 · commit ceee045b3572 · 2025-05-10T01:15:46.000-04:00
diff --git a/code/controlconfig/controlsconfig.cpp b/code/controlconfig/controlsconfig.cpp
@@ -1348,7 +1348,7 @@ bool control_config_accept(bool API_Access)
 
 			// Pack the current bindings into a preset, then save the file
 			CC_preset preset;
-			preset.name = str;
+			preset.name = std::move(str);
 			std::copy(Control_config.begin(), Control_config.end(), std::back_inserter(preset.bindings));
 			Control_config_presets.push_back(preset);
 			save_preset_file(preset, true);
diff --git a/code/hud/hudsquadmsg.cpp b/code/hud/hudsquadmsg.cpp
@@ -207,7 +207,7 @@ void hud_squadmsg_start()
 		auto paramList = scripting::hook_param_list(scripting::hook_param("Player", 'o', Player_obj));
 		if (scripting::hooks::OnHudCommMenuOpened->isOverride(paramList))
 		{
-			scripting::hooks::OnHudCommMenuOpened->run(paramList);
+			scripting::hooks::OnHudCommMenuOpened->run(std::move(paramList));
 			return;
 		}
 	}
@@ -243,7 +243,7 @@ void hud_squadmsg_end()
 		auto paramList = scripting::hook_param_list(scripting::hook_param("Player", 'o', Player_obj));
 		if (scripting::hooks::OnHudCommMenuClosed->isOverride(paramList))
 		{
-			scripting::hooks::OnHudCommMenuClosed->run(paramList);
+			scripting::hooks::OnHudCommMenuClosed->run(std::move(paramList));
 			return;
 		}
 	}
@@ -2007,7 +2007,7 @@ void hud_squadmsg_reinforcement_select()
 			}
 
 			Assert ( Num_menu_items < MAX_MENU_ITEMS );
-			MsgItems[Num_menu_items].text = rp_name;
+			MsgItems[Num_menu_items].text = std::move(rp_name);
 			MsgItems[Num_menu_items].instance = i;
 			MsgItems[Num_menu_items].active = 0;
 
diff --git a/code/model/animation/modelanimation.cpp b/code/model/animation/modelanimation.cpp
@@ -1084,7 +1084,7 @@ namespace animation {
 				return submodel;
 		}
 
-		auto submodel = std::shared_ptr<ModelAnimationSubmodel>(new ModelAnimationSubmodel(submodelName));
+		auto submodel = std::make_shared<ModelAnimationSubmodel>(std::move(submodelName));
 		m_submodels.push_back(submodel);
 		return submodel;
 	}
@@ -1100,7 +1100,7 @@ namespace animation {
 			}
 		}
 
-		auto submodel = std::shared_ptr<ModelAnimationSubmodelTurret>(new ModelAnimationSubmodelTurret(submodelName, findBarrel, SIP_name));
+		auto submodel = std::make_shared<ModelAnimationSubmodelTurret>(std::move(submodelName), findBarrel, SIP_name);
 		m_submodels.push_back(submodel);
 		return submodel;
 	}
@@ -1360,7 +1360,7 @@ namespace animation {
 
 		animation->setAnimation(helper.parseSegment());
 
-		s_animationsById.emplace(helper.m_animationName, ParsedModelAnimation { animation, type, name, subtype });
+		s_animationsById.emplace(helper.m_animationName, ParsedModelAnimation { std::move(animation), type, std::move(name), subtype });
 	}
 
 	void ModelAnimationParseHelper::parseSingleMoveable() {
@@ -1699,7 +1699,7 @@ namespace animation {
 			}
 			else {
 				auto subsys = sip->animations.getSubmodel(sp->subobj_name);
-				auto rot = std::shared_ptr<ModelAnimationSegmentSetOrientation>(new ModelAnimationSegmentSetOrientation(subsys, angle, isRelative ? ModelAnimationCoordinateRelation::RELATIVE_COORDS : ModelAnimationCoordinateRelation::ABSOLUTE_COORDS));
+				auto rot = std::make_shared<ModelAnimationSegmentSetOrientation>(std::move(subsys), angle, isRelative ? ModelAnimationCoordinateRelation::RELATIVE_COORDS : ModelAnimationCoordinateRelation::ABSOLUTE_COORDS);
 				anim->setAnimation(std::move(rot));
 			}
 
diff --git a/code/model/animation/modelanimation_moveables.cpp b/code/model/animation/modelanimation_moveables.cpp
@@ -178,7 +178,7 @@ namespace animation {
 
 		auto sequence = std::shared_ptr<ModelAnimationSegmentSerial>(new ModelAnimationSegmentSerial());
 		sequence->addSegment(std::shared_ptr<ModelAnimationSegment>(new ModelAnimationSegmentSetOffset(submodel, m_defaultOffset, ModelAnimationCoordinateRelation::RELATIVE_COORDS)));
-		sequence->addSegment(std::shared_ptr<ModelAnimationSegment>(new ModelAnimationSegmentTranslation(submodel, m_defaultOffset, m_velocity, std::nullopt, m_acceleration, ModelAnimationSegmentTranslation::CoordinateSystem::COORDS_PARENT, ModelAnimationCoordinateRelation::ABSOLUTE_COORDS)));
+		sequence->addSegment(std::shared_ptr<ModelAnimationSegment>(new ModelAnimationSegmentTranslation(std::move(submodel), m_defaultOffset, m_velocity, std::nullopt, m_acceleration, ModelAnimationSegmentTranslation::CoordinateSystem::COORDS_PARENT, ModelAnimationCoordinateRelation::ABSOLUTE_COORDS)));
 
 		anim->setAnimation(sequence);
 
@@ -377,7 +377,7 @@ namespace animation {
 			auto submodel = parentSet->getSubmodel(link.submodel);
 			auto rotation = std::make_shared<ModelAnimationSegmentRotation>(submodel, std::optional<angles>({0,0,0}), std::nullopt, m_time, link.acceleration, ModelAnimationCoordinateRelation::ABSOLUTE_COORDS);
 			parallelIK->addSegment(rotation);
-			segment->m_chain.push_back({submodel, link.constraint, rotation});
+			segment->m_chain.push_back({submodel, link.constraint, std::move(rotation)});
 		}
 		
 		sequence->addSegment(segment);
@@ -432,7 +432,7 @@ namespace animation {
 			} else
 				constraint = std::shared_ptr<ik_constraint>(new ik_constraint());
 
-			chain.push_back({submodel, constraint, acceleration});
+			chain.push_back({std::move(submodel), constraint, acceleration});
 		}
 		
 		return std::shared_ptr<ModelAnimationMoveable>(new ModelAnimationMoveableIK(chain, time));
diff --git a/code/network/psnet2.cpp b/code/network/psnet2.cpp
@@ -1101,7 +1101,7 @@ static bool psnet_explode_ip_string(const char *ip_string, SCP_string &host, SCP
 		host = ip.substr(0, colon);
 		port = ip.substr(colon + 1);
 	} else {
-		host = ip;
+		host = std::move(ip);
 	}
 
 	return true;
diff --git a/code/parse/sexp/LuaSEXP.cpp b/code/parse/sexp/LuaSEXP.cpp
@@ -733,7 +733,7 @@ void LuaSEXP::parseTable() {
 
 			if (new_enum) {
 				type.second = increment_enum_list_id();
-				Dynamic_enums.push_back(thisList);
+				Dynamic_enums.push_back(std::move(thisList));
 			} else {
 				// Not an error but large mods may lose track of their enum names and I thought this would be helpful -Mjn
 				mprintf(("Found previously existing Lua Enum '%s'. Using that for sexp '%s'!\n",
diff --git a/code/parse/sexp/sexp_lookup.cpp b/code/parse/sexp/sexp_lookup.cpp
@@ -92,7 +92,7 @@ void parse_sexp_table(const char* filename) {
 				}
 
 				if (thisList.list.size() > 0) {
-					Dynamic_enums.push_back(thisList);
+					Dynamic_enums.push_back(std::move(thisList));
 					increment_enum_list_id();
 				} else {
 					error_display(0, "Parsed empty enum list '%s'. Ignoring!\n", thisList.name.c_str());
@@ -244,8 +244,8 @@ int add_dynamic_sexp(std::unique_ptr<DynamicSEXP>&& sexp, sexp_oper_type type)
 	global.operator_const_mapping.insert(std::make_pair(new_op.value, std::move(sexp)));
 
 	// Now actually add the operator to the SEXP containers
-	Operators.push_back(new_op);
-	Sexp_help.push_back(new_help);
+	Operators.push_back(std::move(new_op));
+	Sexp_help.push_back(std::move(new_help));
 
 	return new_op.value;
 }
diff --git a/code/pilotfile/plr.cpp b/code/pilotfile/plr.cpp
@@ -1035,7 +1035,7 @@ void pilotfile::plr_reset_data(bool reset_all)
 	scoring_special_t blank_score;
 
 	all_time_stats = blank_score;
-	multi_stats = blank_score;
+	multi_stats = std::move(blank_score);
 
 	// clear variables
 	p->variables.clear();
diff --git a/code/popup/popup.cpp b/code/popup/popup.cpp
@@ -533,7 +533,7 @@ int popup_init(popup_info *pi, int flags)
 			scripting::hook_param("AllowedInput", 's', pi->valid_chars, flags & PF_INPUT));
 
 		scripting::hooks::OnDialogInit->run(paramList);
-		if (scripting::hooks::OnDialogInit->isOverride(paramList))
+		if (scripting::hooks::OnDialogInit->isOverride(std::move(paramList)))
 			return 0;
 	}
 
@@ -954,7 +954,7 @@ int popup_do(popup_info *pi, int flags)
 				scripting::hook_param("IsDeathPopup", 'b', false));
 
 			scripting::hooks::OnDialogFrame->run(paramList);
-			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(paramList);
+			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(std::move(paramList));
 		}
 
 		if (!isScriptingOverride) {
@@ -1025,7 +1025,7 @@ int popup_do_with_condition(popup_info *pi, int flags, int(*condition)())
 				scripting::hook_param("Text", 's', pi->raw_text));
 
 			scripting::hooks::OnDialogFrame->run(paramList);
-			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(paramList);
+			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(std::move(paramList));
 			gr_flip();
 		}
 
@@ -1398,7 +1398,7 @@ int popup_conditional_do(int (*condition)(), const char *text)
 				scripting::hook_param("Text", 's', pi->raw_text));
 
 			scripting::hooks::OnDialogFrame->run(paramList);
-			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(paramList);
+			isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(std::move(paramList));
 			gr_flip();
 		}
 
diff --git a/code/popup/popupdead.cpp b/code/popup/popupdead.cpp
@@ -244,7 +244,7 @@ void popupdead_start()
 			scripting::hook_param("DeathMessage", 's', Player->death_message.c_str()));
 
 		scripting::hooks::OnDialogInit->run(paramList);
-		if (scripting::hooks::OnDialogInit->isOverride(paramList))
+		if (scripting::hooks::OnDialogInit->isOverride(std::move(paramList)))
 			return;
 	}
 
@@ -496,7 +496,7 @@ int popupdead_do_frame(float  /*frametime*/)
 			scripting::hook_param("Freeze", 'b', static_cast<bool>(popup_active())));
 
 		scripting::hooks::OnDialogFrame->run(paramList);
-		isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(paramList);
+		isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(std::move(paramList));
 	}
 
 	// don't process keys/buttons if another popup is active
diff --git a/code/scripting/api/libs/async.cpp b/code/scripting/api/libs/async.cpp
@@ -149,7 +149,7 @@ ADE_FUNC(resolved,
 		values.push_back(val);
 	}
 
-	return ade_set_args(L, "o", l_Promise.Set(LuaPromise::resolved(values)));
+	return ade_set_args(L, "o", l_Promise.Set(LuaPromise::resolved(std::move(values))));
 }
 
 ADE_FUNC(errored,
@@ -169,7 +169,7 @@ ADE_FUNC(errored,
 		values.push_back(val);
 	}
 
-	return ade_set_args(L, "o", l_Promise.Set(LuaPromise::errored(values)));
+	return ade_set_args(L, "o", l_Promise.Set(LuaPromise::errored(std::move(values))));
 }
 
 ADE_FUNC(run,
@@ -375,7 +375,7 @@ ADE_FUNC(error,
 
 	// Push an errored promise on the stack and then yield the coroutine. The awaiter will get this promise and stop
 	// execution.
-	ade_set_args(L, "o", l_Promise.Set(LuaPromise::errored(values)));
+	ade_set_args(L, "o", l_Promise.Set(LuaPromise::errored(std::move(values))));
 	return lua_yield(L, 1);
 }
 
diff --git a/code/scripting/api/libs/engine.cpp b/code/scripting/api/libs/engine.cpp
@@ -51,7 +51,7 @@ ADE_FUNC(addHook,
 	}
 
 	action.hook.hook_function.language = SC_LUA;
-	action.hook.hook_function.function = hook;
+	action.hook.hook_function.function = std::move(hook);
 
 	if (override_func.isValid()) {
 		action.hook.override_function.language = SC_LUA;
diff --git a/code/scripting/api/libs/multi.cpp b/code/scripting/api/libs/multi.cpp
@@ -43,9 +43,9 @@ namespace scripting {
 			}
 
 			auto rpc = rpc_h_impl::create(L, name);
-			rpc->func = func;
-			rpc->recipient = recipient;
-			rpc->mode = mode;
+			rpc->func = std::move(func);
+			rpc->recipient = std::move(recipient);
+			rpc->mode = std::move(mode);
 			return ade_set_args(L, "o", l_RPC.Set(std::move(rpc)));
 		}
 	}
diff --git a/code/scripting/api/objs/rpc.cpp b/code/scripting/api/objs/rpc.cpp
@@ -46,7 +46,7 @@ ADE_FUNC(__newindex, l_RPC, "function(any arg) => void rpc_body", "Sets the func
 	if (rpc == nullptr)
 		return ade_set_error(L, "b", false);
 
-	rpc->func = func;
+	rpc->func = std::move(func);
 
 	return ade_set_args(L, "u", rpc->func);
 }
diff --git a/code/scripting/doc_parser.cpp b/code/scripting/doc_parser.cpp
@@ -30,7 +30,7 @@ ade_type_info merge_alternatives(const ade_type_info& left, const ade_type_info&
 		elements.insert(elements.end(), right.elements().begin(), right.elements().end());
 	}
 
-	return ade_type_info(ade_type_alternative(elements));
+	return { ade_type_alternative(std::move(elements)) };
 }
 
 class BaseVisitor : public ArgumentListVisitor {
@@ -148,7 +148,7 @@ class ArglistVisitor : public BaseVisitor {
 	{
 		if (any.isNull()) {
 		}
-		return AbstractParseTreeVisitor::aggregateResult(any, nextResult);
+		return AbstractParseTreeVisitor::aggregateResult(std::move(any), nextResult);
 	}
 };
 
@@ -202,17 +202,17 @@ class TypeVisitor : public BaseVisitor {
 
 	antlrcpp::Any visitMap_type(ArgumentListParser::Map_typeContext* context) override
 	{
-		const auto keyType = visit(context->type(0)).as<ade_type_info>();
-		const auto valueType = visit(context->type(1)).as<ade_type_info>();
+		auto keyType = visit(context->type(0)).as<ade_type_info>();
+		auto valueType = visit(context->type(1)).as<ade_type_info>();
 
-		return ade_type_info(ade_type_map(keyType, valueType));
+		return ade_type_info(ade_type_map(std::move(keyType), std::move(valueType)));
 	}
 
 	antlrcpp::Any visitIterator_type(ArgumentListParser::Iterator_typeContext* context) override
 	{
-		const auto valueType = visit(context->type()).as<ade_type_info>();
+		auto valueType = visit(context->type()).as<ade_type_info>();
 
-		return ade_type_info(ade_type_iterator(valueType));
+		return ade_type_info(ade_type_iterator(std::move(valueType)));
 	}
 
 	antlrcpp::Any visitErrorNode(antlr4::tree::ErrorNode* /*node*/) override { return ade_type_info("<error type>"); }
diff --git a/code/ship/ship.cpp b/code/ship/ship.cpp
@@ -13574,9 +13574,9 @@ int ship_fire_primary(object * obj, int force, bool rollback_shot)
 				scripting::hook_param("User", 'o', objp),
 				scripting::hook_param("Target", 'o', target)
 			);
-			auto conditions = scripting::hooks::WeaponUsedConditions{ shipp, target, firedWeapons, true };
+			auto conditions = scripting::hooks::WeaponUsedConditions{ shipp, target, std::move(firedWeapons), true };
 			scripting::hooks::OnWeaponFired->run(conditions, param_list);
-			scripting::hooks::OnPrimaryFired->run(conditions, param_list);
+			scripting::hooks::OnPrimaryFired->run(std::move(conditions), std::move(param_list));
 		}
 	}
 
@@ -14305,7 +14305,7 @@ int ship_fire_secondary( object *obj, int allow_swarm, bool rollback_shot )
 			);
 			auto conditions = scripting::hooks::WeaponUsedConditions{ shipp, target, SCP_vector<int>{ weapon_idx }, false };
 			scripting::hooks::OnWeaponFired->run(conditions, param_list);
-			scripting::hooks::OnSecondaryFired->run(conditions, param_list);
+			scripting::hooks::OnSecondaryFired->run(std::move(conditions), std::move(param_list));
 		}
 	}
 
@@ -14514,7 +14514,7 @@ bool ship_select_next_primary(object *objp, CycleDirection direction)
 				scripting::hook_param("Target", 'o', target)
 			);
 			scripting::hooks::OnWeaponSelected->run(scripting::hooks::WeaponSelectedConditions{ shipp, swp->current_primary_bank, original_bank, true }, param_list);
-			scripting::hooks::OnWeaponDeselected->run(scripting::hooks::WeaponDeselectedConditions{ shipp, swp->current_primary_bank, original_bank, true }, param_list);
+			scripting::hooks::OnWeaponDeselected->run(scripting::hooks::WeaponDeselectedConditions{ shipp, swp->current_primary_bank, original_bank, true }, std::move(param_list));
 		}
 
 		return true;
@@ -14619,7 +14619,7 @@ int ship_select_next_secondary(object *objp)
 					scripting::hook_param("Target", 'o', target)
 				);
 				scripting::hooks::OnWeaponSelected->run(scripting::hooks::WeaponSelectedConditions{ shipp, swp->current_secondary_bank, original_bank, false }, param_list);
-				scripting::hooks::OnWeaponDeselected->run(scripting::hooks::WeaponDeselectedConditions{ shipp, swp->current_secondary_bank, original_bank, false }, param_list);
+				scripting::hooks::OnWeaponDeselected->run(scripting::hooks::WeaponDeselectedConditions{ shipp, swp->current_secondary_bank, original_bank, false }, std::move(param_list));
 			}
 
 			return 1;
@@ -20834,9 +20834,9 @@ void parse_ai_target_priorities()
 	temp_strings.clear();
 
 	if (already_exists == -1) {
-		Ai_tp_list.push_back(temp_priority);
+		Ai_tp_list.push_back(std::move(temp_priority));
 	} else {
-		Ai_tp_list[already_exists] = temp_priority;
+		Ai_tp_list[already_exists] = std::move(temp_priority);
 	}
 }
 
diff --git a/code/ship/shipfx.cpp b/code/ship/shipfx.cpp
@@ -596,7 +596,7 @@ static void shipfx_actually_warpout(ship *shipp, object *objp)
 		auto params = scripting::hook_param_list(scripting::hook_param("Self", 'o', objp));
 		auto conditions = scripting::hooks::ShipSourceConditions{ shipp };
 		if (OnWarpOutCompleteHook->isOverride(conditions, params)) {
-			OnWarpOutCompleteHook->run(conditions, params);
+			OnWarpOutCompleteHook->run(conditions, std::move(params));
 			return;
 		}
 	}
diff --git a/freespace2/freespace.cpp b/freespace2/freespace.cpp
@@ -5278,7 +5278,7 @@ void game_leave_state( int old_state, int new_state )
 
 		if (scripting::hooks::OnStateEndHook->isActive() && scripting::hooks::OnStateEndHook->isOverride(script_param_list))
 		{
-			scripting::hooks::OnStateEndHook->run(script_param_list);
+			scripting::hooks::OnStateEndHook->run(std::move(script_param_list));
 			return;
 		}
 	}
@@ -6295,7 +6295,7 @@ void mouse_force_pos(int x, int y);
 
 	//WMC - now do user scripting stuff
 	if (scripting::hooks::OnStateStart->isActive()) {
-		scripting::hooks::OnStateStart->run(script_param_list);
+		scripting::hooks::OnStateStart->run(std::move(script_param_list));
 	}
 }
 
diff --git a/test/src/actions/expression/test_ExpressionParser.cpp b/test/src/actions/expression/test_ExpressionParser.cpp
@@ -20,7 +20,7 @@ TEST_P(ExpressionRandomRangeTest, random_range_exec)
 
 	std::tie(expressionText, expectedReturnType, lowerBound, upperBound) = GetParam();
 
-	ExpressionParser parser(expressionText);
+	ExpressionParser parser(std::move(expressionText));
 
 	const auto expression = parser.parse({});
 
@@ -86,7 +86,7 @@ TEST_P(ExpressionExecutionTest, operator_execution)
 	variables.setValue({"test", "test1"}, Value(vm_vec_new(3.f, 4.f, 5.f)));
 	variables.setValue({"test", "test2"}, Value(8.f));
 
-	ExpressionParser parser(expressionText);
+	ExpressionParser parser(std::move(expressionText));
 
 	const auto expression = parser.parse(context);
 

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ void hud_squadmsg_start()`
`207`	`207`	`auto paramList = scripting::hook_param_list(scripting::hook_param("Player", 'o', Player_obj));`
`208`	`208`	`if (scripting::hooks::OnHudCommMenuOpened->isOverride(paramList))`
`209`	`209`	`{`
`210`		`- scripting::hooks::OnHudCommMenuOpened->run(paramList);`
	`210`	`+ scripting::hooks::OnHudCommMenuOpened->run(std::move(paramList));`
`211`	`211`	`return;`
`212`	`212`	`}`
`213`	`213`	`}`
`@@ -243,7 +243,7 @@ void hud_squadmsg_end()`
`243`	`243`	`auto paramList = scripting::hook_param_list(scripting::hook_param("Player", 'o', Player_obj));`
`244`	`244`	`if (scripting::hooks::OnHudCommMenuClosed->isOverride(paramList))`
`245`	`245`	`{`
`246`		`- scripting::hooks::OnHudCommMenuClosed->run(paramList);`
	`246`	`+ scripting::hooks::OnHudCommMenuClosed->run(std::move(paramList));`
`247`	`247`	`return;`
`248`	`248`	`}`
`249`	`249`	`}`
`@@ -2007,7 +2007,7 @@ void hud_squadmsg_reinforcement_select()`
`2007`	`2007`	`}`
`2008`	`2008`
`2009`	`2009`	`Assert ( Num_menu_items < MAX_MENU_ITEMS );`
`2010`		`- MsgItems[Num_menu_items].text = rp_name;`
	`2010`	`+ MsgItems[Num_menu_items].text = std::move(rp_name);`
`2011`	`2011`	`MsgItems[Num_menu_items].instance = i;`
`2012`	`2012`	`MsgItems[Num_menu_items].active = 0;`
`2013`	`2013`
Original file line number	Diff line number	Diff line change
`@@ -1084,7 +1084,7 @@ namespace animation {`
`1084`	`1084`	`return submodel;`
`1085`	`1085`	`}`
`1086`	`1086`
`1087`		`- auto submodel = std::shared_ptr<ModelAnimationSubmodel>(new ModelAnimationSubmodel(submodelName));`
	`1087`	`+ auto submodel = std::make_shared<ModelAnimationSubmodel>(std::move(submodelName));`
`1088`	`1088`	`m_submodels.push_back(submodel);`
`1089`	`1089`	`return submodel;`
`1090`	`1090`	`}`
`@@ -1100,7 +1100,7 @@ namespace animation {`
`1100`	`1100`	`}`
`1101`	`1101`	`}`
`1102`	`1102`
`1103`		`- auto submodel = std::shared_ptr<ModelAnimationSubmodelTurret>(new ModelAnimationSubmodelTurret(submodelName, findBarrel, SIP_name));`
	`1103`	`+ auto submodel = std::make_shared<ModelAnimationSubmodelTurret>(std::move(submodelName), findBarrel, SIP_name);`
`1104`	`1104`	`m_submodels.push_back(submodel);`
`1105`	`1105`	`return submodel;`
`1106`	`1106`	`}`
`@@ -1360,7 +1360,7 @@ namespace animation {`
`1360`	`1360`
`1361`	`1361`	`animation->setAnimation(helper.parseSegment());`
`1362`	`1362`
`1363`		`- s_animationsById.emplace(helper.m_animationName, ParsedModelAnimation { animation, type, name, subtype });`
	`1363`	`+ s_animationsById.emplace(helper.m_animationName, ParsedModelAnimation { std::move(animation), type, std::move(name), subtype });`
`1364`	`1364`	`}`
`1365`	`1365`
`1366`	`1366`	`void ModelAnimationParseHelper::parseSingleMoveable() {`
`@@ -1699,7 +1699,7 @@ namespace animation {`
`1699`	`1699`	`}`
`1700`	`1700`	`else {`
`1701`	`1701`	`auto subsys = sip->animations.getSubmodel(sp->subobj_name);`
`1702`		`- auto rot = std::shared_ptr<ModelAnimationSegmentSetOrientation>(new ModelAnimationSegmentSetOrientation(subsys, angle, isRelative ? ModelAnimationCoordinateRelation::RELATIVE_COORDS : ModelAnimationCoordinateRelation::ABSOLUTE_COORDS));`
	`1702`	`+ auto rot = std::make_shared<ModelAnimationSegmentSetOrientation>(std::move(subsys), angle, isRelative ? ModelAnimationCoordinateRelation::RELATIVE_COORDS : ModelAnimationCoordinateRelation::ABSOLUTE_COORDS);`
`1703`	`1703`	`anim->setAnimation(std::move(rot));`
`1704`	`1704`	`}`
`1705`	`1705`
Original file line number	Diff line number	Diff line change
`@@ -1101,7 +1101,7 @@ static bool psnet_explode_ip_string(const char *ip_string, SCP_string &host, SCP`
`1101`	`1101`	`host = ip.substr(0, colon);`
`1102`	`1102`	`port = ip.substr(colon + 1);`
`1103`	`1103`	`} else {`
`1104`		`- host = ip;`
	`1104`	`+ host = std::move(ip);`
`1105`	`1105`	`}`
`1106`	`1106`
`1107`	`1107`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ void popupdead_start()`
`244`	`244`	`scripting::hook_param("DeathMessage", 's', Player->death_message.c_str()));`
`245`	`245`
`246`	`246`	`scripting::hooks::OnDialogInit->run(paramList);`
`247`		`- if (scripting::hooks::OnDialogInit->isOverride(paramList))`
	`247`	`+ if (scripting::hooks::OnDialogInit->isOverride(std::move(paramList)))`
`248`	`248`	`return;`
`249`	`249`	`}`
`250`	`250`
`@@ -496,7 +496,7 @@ int popupdead_do_frame(float /frametime/)`
`496`	`496`	`scripting::hook_param("Freeze", 'b', static_cast<bool>(popup_active())));`
`497`	`497`
`498`	`498`	`scripting::hooks::OnDialogFrame->run(paramList);`
`499`		`- isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(paramList);`
	`499`	`+ isScriptingOverride = scripting::hooks::OnDialogFrame->isOverride(std::move(paramList));`
`500`	`500`	`}`
`501`	`501`
`502`	`502`	`// don't process keys/buttons if another popup is active`