Qtfred cleanup pass (scp-fs2open#7345)

* set line edit fields to max length in code

* fix some dialog window titles

* remove unused context help button on Windows

* address some easy todo items

* static access

Author: MjnMixael

code/missioneditor/common.cpp

@@ -25,6 +25,29 @@ SCP_string Voice_script_instructions_string = "$name - name of the message\r\n"
                                               "$note - message notes\r\n\r\n"
                                               "Note that $persona and $sender will only appear for the Message section.";
 
+// TODO: The implementation here is a direct copy of what was in the original FRED code. It is not clear whether the
+// original implementation was intentionally designed to produce the same output as the incorrect implementations in the
+// two editors, or whether it was intended to be a correct normalization but was implemented incorrectly. If the former,
+// then this implementation should be changed to produce the same output as the original implementations in the two
+// editors, even if that output is mathematically incorrect. If the latter, then this implementation should be changed
+// to produce correct normalization into [-180, 180] using a step of 360 instead of 180. This should be evaluated and
+// decided upon before making any changes to this implementation.
+
+// NOTE: FRED and QtFRED Relative coordinates used this version exactly while QtFRED Object orient editor used the
+// correct 360 step version. This version was preserved here to avoid silent behavior changes to FRED during a routine 
+// cleanup pass. This should be fixed intentionally in a dedicated pass once the impact on both editors has been evaluated.
+float normalize_degrees(float deg)
+{
+	while (deg < -180.0f)
+		deg += 180.0f; // was 360.0f in the qtfred object orient version, but this is the original FRED implementation
+	while (deg > 180.0f)
+		deg -= 180.0f; // was 360.0f in the qtfred object orient version, but this is the original FRED implementation
+	// check for negative zero
+	if (deg == -0.0f)
+		deg = 0.0f;
+	return deg;
+}
+
 void time_to_mission_info_string(const std::tm* src, char* dest, size_t dest_max_len)
 {
 	std::strftime(dest, dest_max_len, "%x at %X", src);

code/missioneditor/common.h

@@ -3,6 +3,15 @@
 #include "mission/missionmessage.h"
 #include "ship/anchor_t.h"
 
+// Default AWACS range applied when the nebula intensity is unset or invalid
+constexpr float DEFAULT_NEBULA_RANGE = 3000.0f;
+
+// Smallest meaningful change in an orientation input field (degrees)
+constexpr float ORIENT_INPUT_THRESHOLD = 0.01f;
+
+// Normalize a degree value into the range [-180, 180]
+float normalize_degrees(float deg);
+
 // Voice acting manager
 #define INVALID_MESSAGE ((MMessage*)SIZE_MAX) // was originally SIZE_T_MAX but that wasn't available outside fred. May need more research.
 

fred2/bgbitmapdlg.cpp

@@ -27,6 +27,7 @@
 #include "parse/parselo.h"
 #include "starfield/starfield.h"
 #include "starfield/nebula.h"
+#include "missioneditor/common.h"
 #include <vcruntime.h>
 
 #ifdef _DEBUG
@@ -428,7 +429,7 @@ void bg_bitmap_dlg::OnClose()
 
 		// override dumb values with reasonable ones
 		if(Neb2_awacs <= 0.00000001f){
-			Neb2_awacs = 3000.0f;
+			Neb2_awacs = DEFAULT_NEBULA_RANGE;
 		}
 
 		// store poof flags

fred2/orienteditor.cpp

@@ -21,7 +21,6 @@
 static char THIS_FILE[] = __FILE__;
 #endif
 
-constexpr auto INPUT_THRESHOLD = 0.01f;		// smallest increment of input box
 constexpr auto INPUT_FORMAT = "%.01f";
 
 static bool Select_set_relative = false;
@@ -205,7 +204,7 @@ bool orient_editor::is_close(float val, const CString &input_str) const
 	float input_val = convert(input_str);
 
 	float diff = val - input_val;
-	return abs(diff) < INPUT_THRESHOLD;
+	return abs(diff) < ORIENT_INPUT_THRESHOLD;
 }
 
 /**
@@ -217,7 +216,7 @@ bool orient_editor::is_angle_close(float rad, const CString &input_str) const
 	float input_deg = normalize_degrees(convert(input_str));
 
 	float diff = deg - input_deg;
-	return abs(diff) < INPUT_THRESHOLD;
+	return abs(diff) < ORIENT_INPUT_THRESHOLD;
 }
 
 bool orient_editor::query_modified()
@@ -418,18 +417,6 @@ float orient_editor::to_degrees(float rad)
 	return normalize_degrees(deg);
 }
 
-float orient_editor::normalize_degrees(float deg)
-{
-	while (deg < -180.0f)
-		deg += 180.0f;
-	while (deg > 180.0f)
-		deg -= 180.0f;
-	// check for negative zero...
-	if (deg == -0.0f)
-		return 0.0f;
-	return deg;
-}
-
 /**
  * Extract a float from the CString, being mindful of any comma separators.
  */

fred2/orienteditor.h

@@ -10,6 +10,7 @@
 
 
 #include "object/object.h"
+#include "missioneditor/common.h"
 
 /////////////////////////////////////////////////////////////////////////////
 // orient_editor dialog
@@ -24,7 +25,6 @@ class orient_editor : public CDialog
 	orient_editor(CWnd* pParent = NULL);   // standard constructor
 
 	static float to_degrees(float radians);
-	static float normalize_degrees(float degrees);
 
 // Dialog Data
 	//{{AFX_DATA(orient_editor)

qtfred/src/main.cpp

@@ -98,6 +98,7 @@ int main(int argc, char* argv[]) {
 	QCoreApplication::setApplicationName("qtFRED");
 
 	QApplication app(argc, argv);
+	QApplication::setAttribute(Qt::AA_DisableWindowContextHelpButton);
 
 	// Expect that the platform library is in the same directory
 	QCoreApplication::addLibraryPath(QCoreApplication::applicationDirPath());	

qtfred/src/mission/Editor.cpp

@@ -1122,7 +1122,7 @@ int Editor::common_object_delete(int obj) {
 
 	} else if (type == OBJ_POINT) {
 		/*
-		 TODO: Implement vriefing dialog
+		 TODO: Implement briefing dialog
 
 		Assert(Briefing_dialog);
 		Briefing_dialog->delete_icon(Objects[obj].instance);
@@ -2151,12 +2151,6 @@ int Editor::global_error_check_impl() {
 			strcpy(names[obj_count], buf);
 			err_flags[obj_count] = 1;
 		} else if (ptr->type == OBJ_POINT) {
-			// TODO: Fix this once the briefing dialog exists
-			/*
-			if (!Briefing_dialog) {
-				return internal_error("Briefing icon detected when not in briefing edit mode");
-			}
-			 */
 			//Shouldn't be needed anymore.
 			//If we really do need it, call me and I'll write a is_valid function for jumpnodes -WMC
 		} else if (ptr->type == OBJ_JUMP_NODE) {

qtfred/src/mission/EditorViewport.cpp

@@ -1085,9 +1085,7 @@ int EditorViewport::drag_objects(int x, int y)
 	if (!query_valid_object(editor->currentObject) || Lookat_mode)
 		return -1;
 
-	if (Dup_drag == 1
-		//&& (Briefing_dialog) TODO
-		) {
+	if (Dup_drag == 1) {
 		Dup_drag = 0;
 	}
 
@@ -1182,12 +1180,6 @@ int EditorViewport::drag_objects(int x, int y)
 		}
 	}
 
-	/*
-	TODO: Implement brieding dialog
-	if (Briefing_dialog)
-		Briefing_dialog->update_positions();
-	 */
-
 	editor->missionChanged();
 	return rval;
 }

qtfred/src/mission/dialogs/BackgroundEditorDialogModel.cpp

@@ -7,10 +7,8 @@
 #include "nebula/neb.h"
 #include "nebula/neblightning.h"
 #include "starfield/nebula.h"
-#include "lighting/lighting_profiles.h" 
-
-// TODO move this to common for both FREDs.
-const static float default_nebula_range = 3000.0f;
+#include "lighting/lighting_profiles.h"
+#include "missioneditor/common.h"
 
 extern void parse_one_background(background_t* background);
 
@@ -37,7 +35,7 @@ bool BackgroundEditorDialogModel::apply()
 	// ours is a limited spinbox so this probably isn't necessary anymore??
 	// Does this mean range can never be 0?????????
 	if (Neb2_awacs <= 0.00000001f) {
-		Neb2_awacs = 3000.0f;
+		Neb2_awacs = DEFAULT_NEBULA_RANGE;
 	}
 	return true;
 }
@@ -59,7 +57,7 @@ void BackgroundEditorDialogModel::refreshBackgroundPreview()
 background_t& BackgroundEditorDialogModel::getActiveBackground()
 {
 	if (!SCP_vector_inbounds(Backgrounds, Cur_background)) {
-		// Fall back to first background if Cur_background isn’t set
+		// Fall back to first background if Cur_background isn't set
 		Cur_background = 0;
 	}
 	return Backgrounds[Cur_background];
@@ -761,7 +759,7 @@ void BackgroundEditorDialogModel::setFullNebulaEnabled(bool enabled)
 
 		// Set defaults if needed
 		if (Neb2_awacs <= 0.0f) {
-			modify(Neb2_awacs, default_nebula_range);
+			modify(Neb2_awacs, DEFAULT_NEBULA_RANGE);
 		}
 	} else {
 		// Disable full nebula

qtfred/src/mission/dialogs/BriefingEditorDialogModel.cpp

@@ -1,8 +1,7 @@
 #include "BriefingEditorDialogModel.h"
 
 #include "gamesnd/eventmusic.h"
-#include "mission/missionparse.h"      //TODO remove?
-#include "missionui/missioncmdbrief.h" //TODO remove?
+#include "mission/missionparse.h"
 #include "sound/audiostr.h"
 #include "iff_defs/iff_defs.h"
 
@@ -164,8 +163,8 @@ void BriefingEditorDialogModel::addStage()
 	if (_currentStage > 0) {
 		const brief_stage& prev = _wipBriefings[_currentTeam].stages[_currentStage - 1];
 
-		dst = prev; // start by copying everything…
-		// …then clear fields that should not carry over by default
+		dst = prev; // start by copying everything
+		// then clear fields that should not carry over by default
 		dst.text = "<Text here>";
 		dst.voice[0] = '\0';
 	} else {
@@ -665,7 +664,7 @@ int BriefingEditorDialogModel::getIconShipTypeIndex() const
 	const auto& s = b.stages[_currentStage];
 	if (_currentIcon < 0 || _currentIcon >= s.num_icons)
 		return -1;
-	return s.icons[_currentIcon].ship_class; // may be -1 for “unset” depending on icon type
+	return s.icons[_currentIcon].ship_class; // may be -1 for "unset" depending on icon type
 }
 
 void BriefingEditorDialogModel::setIconShipTypeIndex(int idx)
@@ -1042,7 +1041,7 @@ void BriefingEditorDialogModel::makeIcon(const SCP_string& label, int typeIndex,
 			for (int i = 0; i < bs.num_icons; ++i)
 				maxId = std::max(maxId, bs.icons[i].id);
 		}
-		return maxId + 1; // unique within this team’s briefing
+		return maxId + 1; // unique within this team's briefing
 	};
 
 	// Clamp incoming indices to safe ranges