Skip to content

Commit 8039be1

Browse files
Ruslan FarkhutdinovRuslan FarkhutdinovEugeniyKiyashko
authored
FileUploader: Remove excess padding added when showFileList = false (T1295157) (DevExpress#30018)
Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com> Co-authored-by: EugeniyKiyashko <EugeniyKiyashko@users.noreply.github.com>
1 parent 6f16fc2 commit 8039be1

11 files changed

Lines changed: 55 additions & 1 deletion

.github/workflows/pr-filter-stubs.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -705,3 +705,25 @@ jobs:
705705
runs-on: ubuntu-latest
706706
steps:
707707
- run: exit 1
708+
testcafe_tests58:
709+
name: 'fileUploader'
710+
needs: [ changesSegregation ]
711+
if: false
712+
runs-on: ubuntu-latest
713+
steps:
714+
- run: exit 1
715+
testcafe_tests59:
716+
name: 'fileUploader - fluent'
717+
needs: [ changesSegregation ]
718+
if: false
719+
runs-on: ubuntu-latest
720+
steps:
721+
- run: exit 1
722+
testcafe_tests60:
723+
name: 'fileUploader - material'
724+
needs: [ changesSegregation ]
725+
if: false
726+
runs-on: ubuntu-latest
727+
steps:
728+
- run: exit 1
729+

.github/workflows/testcafe_tests.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,9 @@ jobs:
167167
# { componentFolder: "pagination", name: "pagination - material", theme: 'material.blue.light' },
168168
{ componentFolder: "pagination", name: "pagination - fluent", theme: 'fluent.blue.light' },
169169
{ componentFolder: "gantt", name: "gantt" },
170+
{ componentFolder: "fileUploader", name: "fileUploader" },
171+
{ componentFolder: "fileUploader", name: "fileUploader - material", theme: 'material.blue.light' },
172+
{ componentFolder: "fileUploader", name: "fileUploader - fluent", theme: 'fluent.blue.light' },
170173
]
171174
runs-on: devextreme-shr2
172175
timeout-minutes: 45
4.76 KB
Loading
4.36 KB
Loading
4.68 KB
Loading
9.39 KB
Loading
9.17 KB
Loading
9.08 KB
Loading
6.93 KB
Loading
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
2+
import FileUploader from 'devextreme-testcafe-models/fileUploader';
3+
import { testScreenshot } from '../../helpers/themeUtils';
4+
import { createWidget } from '../../helpers/createWidget';
5+
import url from '../../helpers/getPageUrl';
6+
7+
const TEST_FILE = './images/test-image-1.png';
8+
9+
fixture`FileUploader - file list visibility`
10+
.page(url(__dirname, '../container.html'));
11+
12+
[true, false].forEach((showFileList) => {
13+
test(`FileUploader with showFileList: ${showFileList} - after file selected`, async (t) => {
14+
const fileUploader = new FileUploader('#container');
15+
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
16+
17+
await t.setFilesToUpload(fileUploader.input, [TEST_FILE]);
18+
19+
await testScreenshot(t, takeScreenshot, `fileuploader-show-filelist-${showFileList}.png`, {
20+
element: '#container',
21+
});
22+
23+
await t.clearUpload(fileUploader.input);
24+
25+
await t.expect(compareResults.isValid()).ok(compareResults.errorMessages());
26+
}).before(async () => createWidget('dxFileUploader', { showFileList }));
27+
});

0 commit comments

Comments
 (0)