fix: Failing refresh causing crashes

plajdo · plajdo · commit 58c68e9970ce · 2025-08-29T14:25:28.000+02:00
diff --git a/Sources/GoodNetworking/Interception/AuthenticationInterceptor.swift b/Sources/GoodNetworking/Interception/AuthenticationInterceptor.swift
@@ -23,13 +23,14 @@ public final class AuthenticationInterceptor<AuthenticatorType: Authenticator>:
 
     public func adapt(urlRequest: inout URLRequest) async throws(NetworkError) {
         await lock.lock()
+        defer { lock.unlock() }
+        
         if let credential = await authenticator.getCredential() {
             if let refreshableCredential = credential as? RefreshableCredential, refreshableCredential.requiresRefresh {
                 try await refresh(credential: credential)
             }
             try await authenticator.apply(credential: credential, to: &urlRequest)
         }
-        lock.unlock()
     }
 
     public func retry(urlRequest: inout URLRequest, for session: NetworkSession, dueTo error: NetworkError) async throws(NetworkError) -> RetryResult {

Original file line number	Diff line number	Diff line change
`@@ -23,13 +23,14 @@ public final class AuthenticationInterceptor<AuthenticatorType: Authenticator>:`
`23`	`23`
`24`	`24`	`public func adapt(urlRequest: inout URLRequest) async throws(NetworkError) {`
`25`	`25`	`await lock.lock()`
	`26`	`+ defer { lock.unlock() }`
	`27`	`+`
`26`	`28`	`if let credential = await authenticator.getCredential() {`
`27`	`29`	`if let refreshableCredential = credential as? RefreshableCredential, refreshableCredential.requiresRefresh {`
`28`	`30`	`try await refresh(credential: credential)`
`29`	`31`	`}`
`30`	`32`	`try await authenticator.apply(credential: credential, to: &urlRequest)`
`31`	`33`	`}`
`32`		`- lock.unlock()`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`public func retry(urlRequest: inout URLRequest, for session: NetworkSession, dueTo error: NetworkError) async throws(NetworkError) -> RetryResult {`