Merge pull request #12 from GoodRequest/coordinator-update

feat: GoodCoordinator init update

Author: plajdo

GoodReactor-Sample/GoodReactor-Sample/Coordinators/AppCoordinator.swift

@@ -25,13 +25,15 @@ final class AppCoordinator: GoodCoordinator<AppStep> {
 
     init(window: UIWindow?) {
         self.window = window
+        
+        super.init()
     }
 
-    required init(rootViewController: UIViewController? = nil, parentCoordinator: (any Coordinator)? = nil) {
+    required init(rootViewController: UIViewController? = nil) {
         fatalError("init(rootViewController:parentCoordinator:) has not been implemented")
     }
 
-    required convenience init(parentCoordinator: any Coordinator) {
+    required init(parentCoordinator: Coordinator?) {
         fatalError("init(parentCoordinator:) has not been implemented")
     }
 

GoodReactor-Sample/GoodReactor-Sample/Coordinators/HomeCoordinator.swift

@@ -32,7 +32,6 @@ class HomeCoordinator: GoodCoordinator<HomeStep> {
         switch step {
         case .goToAbout:
             let aboutViewController = AboutCoordinator(
-                rootViewController: rootViewController,
                 parentCoordinator: self
             ).start()
 

Sources/LegacyReactor/GoodCoordinator.swift

@@ -33,7 +33,7 @@ public enum StepAction {
 
     // Links
     case safari(URL, UIModalPresentationStyle = .automatic, tintColor: UIColor? = nil)
-    case universalLink(url: URL, onlyUniversal: Bool, completion: (@MainActor (Bool) -> ())? = nil)
+    case universalLink(url: URL, onlyOpenWhenTargetAppIsAvailable: Bool = false, completion: (@MainActor (Bool) -> ())? = nil)
 
     // Actions
     case call(String)
@@ -89,21 +89,20 @@ open class GoodCoordinator<Step>: NSObject, Coordinator {
     /// - Parameters:
     ///   - rootViewController: The root view controller managed by this coordinator. Default value is nil.
     ///   - parentCoordinator: The parent coordinator of this coordinator. Default value is nil.
-    public required init(rootViewController: UIViewController? = nil, parentCoordinator: Coordinator? = nil) {
+    public required init(rootViewController: UIViewController? = nil) {
         super.init()
 
         self.rootViewController = rootViewController
-        self.parentCoordinator = parentCoordinator
-        self.parentCoordinator?.children.addObject(self)
     }
 
     /// A convenience initializer that initializes a GoodCoordinator with a root view controller derived from the provided parent coordinator.
     /// - Parameter parentCoordinator: The parent coordinator to which this coordinator will belong.
-    public required convenience init(parentCoordinator: Coordinator) {
-        self.init(
-            rootViewController: parentCoordinator.rootViewController,
-            parentCoordinator: parentCoordinator
-        )
+    public required init(parentCoordinator: Coordinator?) {
+        super.init()
+
+        self.parentCoordinator = parentCoordinator
+        self.rootViewController = parentCoordinator?.rootViewController
+        self.parentCoordinator?.children.addObject(self)
     }
 
     // MARK: - Overridable