Merge pull request #14 from GoodRequest/feature/remove-goodLogger

feat: Remove GoodLogger dependency

Author: matusklasovity

GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj

@@ -11,11 +11,7 @@
 		09545AF02CB6704900DC5A61 /* LegacyReactor in Frameworks */ = {isa = PBXBuildFile; productRef = 09545AEF2CB6704900DC5A61 /* LegacyReactor */; };
 		09545AF22CB6705100DC5A61 /* GoodReactor in Frameworks */ = {isa = PBXBuildFile; productRef = 09545AF12CB6705100DC5A61 /* GoodReactor */; };
 		099D61702C83447900B86922 /* GoodCoordinator in Frameworks */ = {isa = PBXBuildFile; productRef = 099D616F2C83447900B86922 /* GoodCoordinator */; };
-		099D61732C8472D300B86922 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 099D61722C8472D300B86922 /* GoodNetworking */; };
-		099D617F2C84A3CC00B86922 /* RandomNumber.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617C2C84A3CC00B86922 /* RandomNumber.swift */; };
-		099D61802C84A3CC00B86922 /* RNGEndpoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617D2C84A3CC00B86922 /* RNGEndpoint.swift */; };
 		3F8C10772D4B7E16000A4CC0 /* GoodCoordinator in Frameworks */ = {isa = PBXBuildFile; productRef = 3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */; };
-		6B9596242D3E690B0037D874 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 6B9596232D3E690B0037D874 /* GoodNetworking */; };
 		EA51F944299424A900B14A7C /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = EA51F943299424A900B14A7C /* AppDelegate.swift */; };
 		EA51F94F299424AA00B14A7C /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA51F94E299424AA00B14A7C /* Assets.xcassets */; };
 		EA51F952299424AA00B14A7C /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = EA51F950299424AA00B14A7C /* LaunchScreen.storyboard */; };
@@ -38,8 +34,6 @@
 
 /* Begin PBXFileReference section */
 		092188B02C8CD2A100C6085A /* goodreactor-swiftui-sample.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "goodreactor-swiftui-sample.app"; sourceTree = BUILT_PRODUCTS_DIR; };
-		099D617C2C84A3CC00B86922 /* RandomNumber.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RandomNumber.swift; sourceTree = "<group>"; };
-		099D617D2C84A3CC00B86922 /* RNGEndpoint.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RNGEndpoint.swift; sourceTree = "<group>"; };
 		5D4A974E299CCA0F00DFAEAE /* GoodReactor */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = GoodReactor; path = ..; sourceTree = "<group>"; };
 		EA51F940299424A900B14A7C /* GoodReactor-Sample.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "GoodReactor-Sample.app"; sourceTree = BUILT_PRODUCTS_DIR; };
 		EA51F943299424A900B14A7C /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
@@ -83,24 +77,13 @@
 			buildActionMask = 2147483647;
 			files = (
 				099D61702C83447900B86922 /* GoodCoordinator in Frameworks */,
-				099D61732C8472D300B86922 /* GoodNetworking in Frameworks */,
 				09545AF02CB6704900DC5A61 /* LegacyReactor in Frameworks */,
-				6B9596242D3E690B0037D874 /* GoodNetworking in Frameworks */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
 /* End PBXFrameworksBuildPhase section */
 
 /* Begin PBXGroup section */
-		099D617E2C84A3CC00B86922 /* Models */ = {
-			isa = PBXGroup;
-			children = (
-				099D617C2C84A3CC00B86922 /* RandomNumber.swift */,
-				099D617D2C84A3CC00B86922 /* RNGEndpoint.swift */,
-			);
-			path = Models;
-			sourceTree = "<group>";
-		};
 		5D4A974D299CCA0F00DFAEAE /* Packages */ = {
 			isa = PBXGroup;
 			children = (
@@ -141,7 +124,6 @@
 			children = (
 				EA51F95D299425A600B14A7C /* Application */,
 				EA751BAF29964F24004016E1 /* Helpers */,
-				099D617E2C84A3CC00B86922 /* Models */,
 				EA51F97E2994E03700B14A7C /* Extensions */,
 				EA51F95E29942B1300B14A7C /* Coordinators */,
 				EA51F96529942B9400B14A7C /* Screens */,
@@ -302,9 +284,7 @@
 			name = "GoodReactor-Sample";
 			packageProductDependencies = (
 				099D616F2C83447900B86922 /* GoodCoordinator */,
-				099D61722C8472D300B86922 /* GoodNetworking */,
 				09545AEF2CB6704900DC5A61 /* LegacyReactor */,
-				6B9596232D3E690B0037D874 /* GoodNetworking */,
 			);
 			productName = "GoodReactor-Sample";
 			productReference = EA51F940299424A900B14A7C /* GoodReactor-Sample.app */;
@@ -338,7 +318,6 @@
 			);
 			mainGroup = EA51F937299424A900B14A7C;
 			packageReferences = (
-				6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */,
 				3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */,
 			);
 			productRefGroup = EA51F941299424A900B14A7C /* Products */;
@@ -398,8 +377,6 @@
 				EABE433C2995128400EB51BD /* Constants.swift in Sources */,
 				EA6B6D8A2994F30E0035186A /* AboutViewController.swift in Sources */,
 				EA6B6D892994F30E0035186A /* AboutViewModel.swift in Sources */,
-				099D617F2C84A3CC00B86922 /* RandomNumber.swift in Sources */,
-				099D61802C84A3CC00B86922 /* RNGEndpoint.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -696,15 +673,7 @@
 			repositoryURL = "https://github.com/GoodRequest/GoodCoordinator-iOS";
 			requirement = {
 				kind = upToNextMajorVersion;
-				minimumVersion = 3.0.3;
-			};
-		};
-		6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */ = {
-			isa = XCRemoteSwiftPackageReference;
-			repositoryURL = "https://github.com/GoodRequest/GoodNetworking";
-			requirement = {
-				branch = "resource-updating";
-				kind = branch;
+				minimumVersion = 3.0.4;
 			};
 		};
 /* End XCRemoteSwiftPackageReference section */
@@ -726,20 +695,11 @@
 			isa = XCSwiftPackageProductDependency;
 			productName = GoodCoordinator;
 		};
-		099D61722C8472D300B86922 /* GoodNetworking */ = {
-			isa = XCSwiftPackageProductDependency;
-			productName = GoodNetworking;
-		};
 		3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */ = {
 			isa = XCSwiftPackageProductDependency;
 			package = 3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */;
 			productName = GoodCoordinator;
 		};
-		6B9596232D3E690B0037D874 /* GoodNetworking */ = {
-			isa = XCSwiftPackageProductDependency;
-			package = 6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */;
-			productName = GoodNetworking;
-		};
 /* End XCSwiftPackageProductDependency section */
 	};
 	rootObject = EA51F938299424A900B14A7C /* Project object */;

GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -6,6 +6,7 @@
 //
 
 import UIKit
+import GoodReactor
 
 @main
 class AppDelegate: UIResponder, UIApplicationDelegate {
@@ -21,8 +22,18 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         UINavigationBar.configureAppearance()
 
         AppCoordinator(window: window).start()
+        
+        ReactorConfiguration.logger = SampleLogger()
 
         return true
     }
 
 }
+
+struct SampleLogger: ReactorLogger {
+    
+    func logReactorEvent(_ message: Any, level: LogLevel, fileName: String, lineNumber: Int) {
+        print("[\(level)] \(message) (\(fileName):\(lineNumber))")
+    }
+    
+}

GoodReactor-Sample/GoodReactor-Sample/Application/AppDelegate.swift

@@ -22,16 +22,14 @@ let package = Package(
     dependencies: [
         .package(url: "https://github.com/CombineCommunity/CombineExt.git", from: "1.8.1"),
         .package(url: "https://github.com/apple/swift-async-algorithms.git", .upToNextMajor(from: "1.0.0")),
-        .package(url: "https://github.com/apple/swift-collections.git", .upToNextMajor(from: "1.1.3")),
-        .package(url: "https://github.com/GoodRequest/GoodLogger.git", .upToNextMajor(from: "1.3.0"))
+        .package(url: "https://github.com/apple/swift-collections.git", .upToNextMajor(from: "1.1.3"))
     ],
     targets: [
         .target(
             name: "GoodReactor",
             dependencies: [
                 .product(name: "AsyncAlgorithms", package: "swift-async-algorithms"),
-                .product(name: "Collections", package: "swift-collections"),
-                .product(name: "GoodLogger", package: "GoodLogger")
+                .product(name: "Collections", package: "swift-collections")
             ],
             path: "./Sources/GoodReactor",
             swiftSettings: [.swiftLanguageMode(.v6)]

GoodReactor-Sample/GoodReactor-Sample/Models/RNGEndpoint.swift

@@ -179,6 +179,19 @@ reactor.stateStream
     .store(in: &cancellables)
 ```
 
+## Logging
+```swift
+struct SampleLogger: ReactorLogger {
+    
+    func logReactorEvent(_ message: Any, level: LogLevel, fileName: String, lineNumber: Int) {
+        print("[\(level)] \(message) (\(fileName):\(lineNumber))")
+    }
+    
+}
+
+ReactorConfiguration.logger = SampleLogger()
+```
+
 # License
 GoodReactor repository is released under the MIT license. See [LICENSE](LICENSE.md) for details.
 

GoodReactor-Sample/GoodReactor-Sample/Models/RandomNumber.swift

@@ -0,0 +1,18 @@
+//
+//  ReactorLogger.swift
+//  GoodReactor
+//
+//  Created by Matus Klasovity on 09/06/2025.
+//
+
+import Foundation
+
+public enum LogLevel {
+    case debug
+}
+
+public protocol ReactorLogger: Sendable {
+    
+    func logReactorEvent(_ message: Any, level: LogLevel, fileName: String, lineNumber: Int)
+        
+}

Package.swift

@@ -5,8 +5,6 @@
 //  Created by Filip Šašala on 27/08/2024.
 //
 
-import GoodLogger
-
 internal enum MapTables {
 
     typealias AnyReactor = AnyObject
@@ -33,7 +31,7 @@ internal enum MapTables {
     static let eventStreams = WeakMapTable<AnyReactor, Any>()
 
     // Logger of a reactor
-    static let loggers = WeakMapTable<AnyReactor, GoodLogger>()
+    static let loggers = WeakMapTable<AnyReactor, ReactorLogger>()
 
     // Semaphore lock of an event (does not matter which reactor it's running on)
     static let eventLocks = WeakMapTable<EventIdentifier, AsyncSemaphore>()