chore: Update tests according skills

Author: GoodbyePlanet

tests/embeddings/test_factory.py

@@ -34,13 +34,13 @@ def reset_factory(monkeypatch):
     monkeypatch.setattr(factory_module, "_provider", None)
 
 
-def test_register_adds_to_registry():
+def test_register_adds_to_registry() -> None:
     register("stub", _StubProvider)
     assert "stub" in factory_module._registry
     assert factory_module._registry["stub"] is _StubProvider
 
 
-def test_get_embedding_provider_instantiates_registered_class(monkeypatch):
+def test_get_embedding_provider_instantiates_registered_class(monkeypatch) -> None:
     register("stub", _StubProvider)
     monkeypatch.setattr(
         "server.embeddings.factory.settings.embeddings_provider", "stub"
@@ -51,7 +51,7 @@ def test_get_embedding_provider_instantiates_registered_class(monkeypatch):
     assert isinstance(provider, _StubProvider)
 
 
-def test_get_embedding_provider_returns_singleton(monkeypatch):
+def test_get_embedding_provider_returns_singleton(monkeypatch) -> None:
     register("stub", _StubProvider)
     monkeypatch.setattr(
         "server.embeddings.factory.settings.embeddings_provider", "stub"
@@ -60,7 +60,7 @@ def test_get_embedding_provider_returns_singleton(monkeypatch):
     assert get_embedding_provider() is get_embedding_provider()
 
 
-def test_get_embedding_provider_raises_for_unknown_name(monkeypatch):
+def test_get_embedding_provider_raises_for_unknown_name(monkeypatch) -> None:
     register("stub", _StubProvider)
     monkeypatch.setattr(
         "server.embeddings.factory.settings.embeddings_provider", "unknown"
@@ -70,7 +70,7 @@ def test_get_embedding_provider_raises_for_unknown_name(monkeypatch):
         get_embedding_provider()
 
 
-def test_error_message_lists_registered_providers(monkeypatch):
+def test_error_message_lists_registered_providers(monkeypatch) -> None:
     register("alpha", _StubProvider)
     register("beta", _StubProvider)
     monkeypatch.setattr(
@@ -81,7 +81,7 @@ def test_error_message_lists_registered_providers(monkeypatch):
         get_embedding_provider()
 
 
-async def test_close_embedding_provider_calls_close_on_provider(monkeypatch):
+async def test_close_embedding_provider_calls_close_on_provider(monkeypatch) -> None:
     provider = _StubProviderWithClose()
     monkeypatch.setattr(factory_module, "_provider", provider)
 
@@ -91,11 +91,11 @@ async def test_close_embedding_provider_calls_close_on_provider(monkeypatch):
     assert factory_module._provider is None
 
 
-async def test_close_embedding_provider_is_noop_when_none():
+async def test_close_embedding_provider_is_noop_when_none() -> None:
     await close_embedding_provider()
 
 
-async def test_close_embedding_provider_skips_close_if_not_defined(monkeypatch):
+async def test_close_embedding_provider_skips_close_if_not_defined(monkeypatch) -> None:
     monkeypatch.setattr(factory_module, "_provider", _StubProvider())
 
     await close_embedding_provider()

tests/embeddings/test_jina.py

@@ -22,7 +22,7 @@ async def provider(jina_settings):
 
 
 @respx.mock
-async def test_embed_batch_posts_to_embed_endpoint(provider):
+async def test_embed_batch_posts_to_embed_endpoint(provider) -> None:
     route = respx.post("http://tei-test:80/embed").mock(
         return_value=httpx.Response(200, json=[[0.1] * 768, [0.2] * 768])
     )
@@ -38,7 +38,7 @@ async def test_embed_batch_posts_to_embed_endpoint(provider):
 
 
 @respx.mock
-async def test_embed_batch_chunks_at_32(provider):
+async def test_embed_batch_chunks_at_32(provider) -> None:
     route = respx.post("http://tei-test:80/embed").mock(
         side_effect=lambda req: httpx.Response(
             200,
@@ -53,7 +53,7 @@ async def test_embed_batch_chunks_at_32(provider):
 
 
 @respx.mock
-async def test_embed_batch_supports_openai_style_response(provider):
+async def test_embed_batch_supports_openai_style_response(provider) -> None:
     respx.post("http://tei-test:80/embed").mock(
         return_value=httpx.Response(200, json={"data": [{"embedding": [0.5] * 768}]})
     )
@@ -62,7 +62,7 @@ async def test_embed_batch_supports_openai_style_response(provider):
 
 
 @respx.mock
-async def test_embed_query_returns_single_vector(provider):
+async def test_embed_query_returns_single_vector(provider) -> None:
     respx.post("http://tei-test:80/embed").mock(
         return_value=httpx.Response(200, json=[[0.3] * 768])
     )
@@ -71,11 +71,11 @@ async def test_embed_query_returns_single_vector(provider):
     assert vec[0] == 0.3
 
 
-async def test_embed_batch_empty_returns_empty(provider):
+async def test_embed_batch_empty_returns_empty(provider) -> None:
     assert await provider.embed_batch([]) == []
 
 
-def test_dimensions_reads_from_settings(jina_settings, monkeypatch):
+def test_dimensions_reads_from_settings(jina_settings, monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_dimensions", 1024)
     p = JinaEmbeddingProvider()
     assert p.dimensions == 1024

tests/embeddings/test_jina_api.py

@@ -29,26 +29,26 @@ def _vectors_response(inputs: list[str], dim: int = 768) -> dict:
     return {"data": [{"embedding": [0.1] * dim} for _ in inputs]}
 
 
-def test_missing_api_key_raises(monkeypatch):
+def test_missing_api_key_raises(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "")
     with pytest.raises(RuntimeError, match="JINA_API_KEY"):
         JinaApiEmbeddingProvider()
 
 
-def test_unknown_model_without_dimensions_raises(monkeypatch):
+def test_unknown_model_without_dimensions_raises(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "k")
     monkeypatch.setattr(settings, "jina_api_model", "jina-future-99")
     monkeypatch.setattr(settings, "jina_api_dimensions", None)
     with pytest.raises(RuntimeError, match="JINA_API_DIMENSIONS"):
         JinaApiEmbeddingProvider()
 
 
-def test_dimensions_native(jina_api_settings):
+def test_dimensions_native(jina_api_settings) -> None:
     p = JinaApiEmbeddingProvider()
     assert p.dimensions == 768  # jina-embeddings-v2-base-code native
 
 
-def test_dimensions_override(monkeypatch):
+def test_dimensions_override(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "k")
     monkeypatch.setattr(settings, "jina_api_model", "jina-code-embeddings-1.5b")
     monkeypatch.setattr(settings, "jina_api_dimensions", 512)
@@ -57,7 +57,7 @@ def test_dimensions_override(monkeypatch):
 
 
 @respx.mock
-async def test_embed_batch_omits_task_for_v2_model(provider):
+async def test_embed_batch_omits_task_for_v2_model(provider) -> None:
     route = respx.post("https://api.jina.ai/v1/embeddings").mock(
         return_value=httpx.Response(200, json=_vectors_response(["a", "b"]))
     )
@@ -71,7 +71,7 @@ async def test_embed_batch_omits_task_for_v2_model(provider):
 
 
 @respx.mock
-async def test_embed_query_omits_task_for_v2_model(provider):
+async def test_embed_query_omits_task_for_v2_model(provider) -> None:
     route = respx.post("https://api.jina.ai/v1/embeddings").mock(
         return_value=httpx.Response(200, json=_vectors_response(["q"]))
     )
@@ -82,7 +82,7 @@ async def test_embed_query_omits_task_for_v2_model(provider):
 
 
 @respx.mock
-async def test_embed_batch_sends_task_for_code_embeddings_model(monkeypatch):
+async def test_embed_batch_sends_task_for_code_embeddings_model(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "test-key")
     monkeypatch.setattr(settings, "jina_api_model", "jina-code-embeddings-1.5b")
     monkeypatch.setattr(settings, "jina_api_dimensions", None)
@@ -99,7 +99,7 @@ async def test_embed_batch_sends_task_for_code_embeddings_model(monkeypatch):
 
 
 @respx.mock
-async def test_embed_query_sends_task_for_code_embeddings_model(monkeypatch):
+async def test_embed_query_sends_task_for_code_embeddings_model(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "test-key")
     monkeypatch.setattr(settings, "jina_api_model", "jina-code-embeddings-1.5b")
     monkeypatch.setattr(settings, "jina_api_dimensions", None)
@@ -116,7 +116,7 @@ async def test_embed_query_sends_task_for_code_embeddings_model(monkeypatch):
 
 
 @respx.mock
-async def test_embed_batch_chunks_at_128(provider):
+async def test_embed_batch_chunks_at_128(provider) -> None:
     route = respx.post("https://api.jina.ai/v1/embeddings").mock(
         side_effect=lambda req: httpx.Response(
             200,
@@ -131,7 +131,7 @@ async def test_embed_batch_chunks_at_128(provider):
 
 
 @respx.mock
-async def test_authorization_header_set(provider):
+async def test_authorization_header_set(provider) -> None:
     route = respx.post("https://api.jina.ai/v1/embeddings").mock(
         return_value=httpx.Response(200, json=_vectors_response(["a"]))
     )
@@ -141,7 +141,7 @@ async def test_authorization_header_set(provider):
 
 
 @respx.mock
-async def test_embed_batch_passes_dimensions_when_overridden(monkeypatch):
+async def test_embed_batch_passes_dimensions_when_overridden(monkeypatch) -> None:
     monkeypatch.setattr(settings, "jina_api_key", "test-key")
     monkeypatch.setattr(settings, "jina_api_model", "jina-code-embeddings-1.5b")
     monkeypatch.setattr(settings, "jina_api_dimensions", 256)
@@ -158,22 +158,22 @@ async def test_embed_batch_passes_dimensions_when_overridden(monkeypatch):
     assert body["dimensions"] == 256
 
 
-async def test_embed_batch_empty(provider):
+async def test_embed_batch_empty(provider) -> None:
     assert await provider.embed_batch([]) == []
 
 
-async def test_embed_batch_raises_on_empty_string(provider):
+async def test_embed_batch_raises_on_empty_string(provider) -> None:
     with pytest.raises(ValueError, match="empty/whitespace"):
         await provider.embed_batch([""])
 
 
-async def test_embed_batch_raises_on_whitespace_only(provider):
+async def test_embed_batch_raises_on_whitespace_only(provider) -> None:
     with pytest.raises(ValueError, match="empty/whitespace"):
         await provider.embed_batch(["   \n\t  "])
 
 
 @respx.mock
-async def test_rate_limit_backoff_delays(provider, monkeypatch):
+async def test_rate_limit_backoff_delays(provider, monkeypatch) -> None:
     sleep_calls: list[float] = []
 
     async def fake_sleep(seconds: float) -> None:
@@ -193,7 +193,7 @@ async def fake_sleep(seconds: float) -> None:
 
 
 @respx.mock
-async def test_rate_limit_honors_retry_after_header(provider, monkeypatch):
+async def test_rate_limit_honors_retry_after_header(provider, monkeypatch) -> None:
     sleep_calls: list[float] = []
 
     async def fake_sleep(seconds: float) -> None:
@@ -211,7 +211,7 @@ async def fake_sleep(seconds: float) -> None:
 
 
 @respx.mock
-async def test_rate_limit_all_retries_exhausted_raises(provider, monkeypatch):
+async def test_rate_limit_all_retries_exhausted_raises(provider, monkeypatch) -> None:
     sleep_calls: list[float] = []
 
     async def fake_sleep(seconds: float) -> None:
@@ -227,7 +227,7 @@ async def fake_sleep(seconds: float) -> None:
 
 
 @respx.mock
-async def test_response_length_mismatch_raises(provider):
+async def test_response_length_mismatch_raises(provider) -> None:
     # Server returns fewer vectors than inputs — should raise ValueError
     respx.post("https://api.jina.ai/v1/embeddings").mock(
         return_value=httpx.Response(200, json=_vectors_response(["only-one"]))

tests/embeddings/test_ollama.py

@@ -28,20 +28,20 @@ def _vectors_response(inputs: list[str], dim: int = 768) -> dict:
     return {"embeddings": [[0.0] * dim for _ in inputs]}
 
 
-def test_unknown_model_without_dimensions_raises(monkeypatch):
+def test_unknown_model_without_dimensions_raises(monkeypatch) -> None:
     monkeypatch.setattr(settings, "ollama_url", "http://ollama-test:11434")
     monkeypatch.setattr(settings, "ollama_model", "totally-custom-embed")
     monkeypatch.setattr(settings, "ollama_dimensions", None)
     with pytest.raises(RuntimeError, match="OLLAMA_DIMENSIONS"):
         OllamaEmbeddingProvider()
 
 
-def test_dimensions_native(ollama_settings):
+def test_dimensions_native(ollama_settings) -> None:
     p = OllamaEmbeddingProvider()
     assert p.dimensions == 768
 
 
-def test_dimensions_override(monkeypatch):
+def test_dimensions_override(monkeypatch) -> None:
     monkeypatch.setattr(settings, "ollama_url", "http://ollama-test:11434")
     monkeypatch.setattr(settings, "ollama_model", "custom-embed")
     monkeypatch.setattr(settings, "ollama_dimensions", 512)
@@ -50,7 +50,7 @@ def test_dimensions_override(monkeypatch):
 
 
 @respx.mock
-async def test_embed_batch_request_shape(provider):
+async def test_embed_batch_request_shape(provider) -> None:
     route = respx.post("http://ollama-test:11434/api/embed").mock(
         return_value=httpx.Response(200, json=_vectors_response(["a", "b"]))
     )
@@ -60,7 +60,7 @@ async def test_embed_batch_request_shape(provider):
 
 
 @respx.mock
-async def test_embed_batch_chunks_at_32(provider):
+async def test_embed_batch_chunks_at_32(provider) -> None:
     route = respx.post("http://ollama-test:11434/api/embed").mock(
         side_effect=lambda req: httpx.Response(
             200,
@@ -75,13 +75,13 @@ async def test_embed_batch_chunks_at_32(provider):
 
 
 @respx.mock
-async def test_embed_query_returns_single_vector(provider):
+async def test_embed_query_returns_single_vector(provider) -> None:
     respx.post("http://ollama-test:11434/api/embed").mock(
         return_value=httpx.Response(200, json=_vectors_response(["q"]))
     )
     vec = await provider.embed_query("q")
     assert len(vec) == 768
 
 
-async def test_embed_batch_empty(provider):
+async def test_embed_batch_empty(provider) -> None:
     assert await provider.embed_batch([]) == []