fix: Docker/CI build hygiene — silent lockfile fallback and setup-uv version mismatch#92
Merged
Merged
Conversation
- Drop silent uv sync fallback in Dockerfile so lockfile drift fails the build loudly instead of producing an unpinned, unsigned image - Split Dockerfile into builder/runtime stages so the runtime image runs python -m server.main directly instead of re-resolving the env via `uv run` at container start, and no longer ships uv - Align setup-uv action version to v7 in both CI lint and test jobs Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #79.
Dockerfileranuv sync --frozen ... 2>/dev/null || uv sync ..., swallowing frozen-install errors and silently falling back to an unpinned resolve on lockfile drift. Now runs a singleuv sync --frozen --no-dev --no-editablethat fails the build loudly instead.builderstage (hasuv, resolves deps into.venv, copies source) and aruntimestage that copies the built/appand runspython -m server.maindirectly. The runtime image no longer re-resolves the environment at container start and no longer shipsuv.setup-uvversions: aligned.github/workflows/ci.ymllint and test jobs to both useastral-sh/setup-uv@v7(previously@v7vs@v5).Test plan
docker build --platform linux/amd64 -t semcode-test .succeeds with the new multi-stage Dockerfiledocker run --rm --platform linux/amd64 semcode-test python -c "import server.main"succeedsuvis not present in the runtime imagesetup-uv@v7🤖 Generated with Claude Code