Update sandbox sample Handlebars bundle#1686
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
1d91088 to
a7fecc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1615
Summary
handlebars-*.jsbundle in ESLint so repo lint checks the sample code rather than third-party distribution output.Notes
The issue also discussed narrowing
postMessage("*"), but the maintainer noted that wildcard targeting is needed for this extension-origin communication path. This PR leaves that messaging behavior unchanged and keeps the scope to the approved Handlebars update.Tests
npm install --ignore-scriptsnpm run lintnpx eslint api-samples/sandbox/sandbox/mainpage.js api-samples/sandbox/sandbox/service-worker.jsnpx prettier --check api-samples/sandbox/sandbox/sandbox.html api-samples/sandbox/sandbox/manifest.json api-samples/sandbox/sandbox/sandbox.md eslint.config.jsapi-samples/sandbox/sandbox/handlebars-4.7.9.jsand rendering both templates fromsandbox.htmlhandlebars@4.7.9dist/handlebars.js, with only trailing whitespace removed forgit diff --checkgit diff --check