Add downloads samples#1716
Merged
Merged
Conversation
the manifest referenced __MSG_extName__ but the locale file never defined extName, so chrome refused to load the extension at all. the icons.html regeneration path called drawIcon without options and used toDataURL, which OffscreenCanvas does not have in a service worker. also drops the Math.TAU global patch, slows the progress poll to 1s, and wakes the worker on downloads.onChanged so badges stay correct after it unloads.
Closed
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
Author
|
@daidr would you be able to sign the CLA? thanks a bunch! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Sorry, just saw this. I checked the CI logs and found I’ve already signed the CLA — looks like someone else still needs to sign it. 
|
patrickkettner
force-pushed
the
downloads-samples
branch
from
July 18, 2026 23:12
152b630 to
beba6ff
Compare
Collaborator
Author
|
oops, sorry for the noise and thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #934 by @daidr, whose commits this branch carries unchanged: four samples for the downloads API (filename controller, download links, download manager, overwrite). On top of his work: a merge with current main, a formatting pass for current prettier, and fixes to download_manager (missing extName locale message that prevented the extension from loading, a broken icon regeneration path in the service worker, and small MV3 lifetime improvements). Resolves #744, closes #934.