Skip to content

Text Replacer example#1718

Merged
patrickkettner merged 9 commits into
GoogleChrome:mainfrom
dotproto:text-replacer
Jul 20, 2026
Merged

Text Replacer example#1718
patrickkettner merged 9 commits into
GoogleChrome:mainfrom
dotproto:text-replacer

Conversation

@dotproto

Copy link
Copy Markdown
Contributor

Adds a sample extension called "Text Replacer." As the name implies, this extension will replace a string in the page with a custom string. Currently supports 5 replacements.

This PR takes the place of #612, which I'm no longer able to directly update.

@google-cla

google-cla Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dotproto dotproto mentioned this pull request Jul 19, 2026

@patrickkettner patrickkettner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch, dude! couple of small things inline, and then

  • the 19px image isn't used (probably remove it?). Also, could you add a 128px image, as thats the size the store requests folks add.
  • Could you add a readme link the sibling functional samples?
  • your google account is still attached to the commit, can you run git commit --amend --no-edit && git push --force-with-lease to clear it out so the CLA doesn't block?

Comment thread functional-samples/sample.text-replacer/manifest.json Outdated
Comment thread functional-samples/sample.text-replacer/text-replacer/content.js Outdated
Comment thread functional-samples/sample.text-replacer/text-replacer/manifest.json Outdated
Comment thread functional-samples/sample.text-replacer/text-replacer/popup.js Outdated
@dotproto

Copy link
Copy Markdown
Contributor Author

@patrickkettner, I think I've covered everything you request and all of the issues identified in #612.

@patrickkettner patrickkettner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits! License comment applies to all files that have BSD at the moment

Comment thread functional-samples/sample.text-replacer/background.js Outdated
Comment thread functional-samples/sample.text-replacer/content.js Outdated
Comment thread functional-samples/sample.text-replacer/content.js Outdated
@dotproto

Copy link
Copy Markdown
Contributor Author

I suggest enabling Code review limits on this repo to prevent drive-by approvals.

@patrickkettner

Copy link
Copy Markdown
Collaborator

thanks!

@patrickkettner
patrickkettner merged commit d4dac0d into GoogleChrome:main Jul 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants