Add downloads samples#934
Conversation
|
The special thing is that eval was used before download_filename_controller to support writing js to modify the name of the downloaded file, but this cannot be used in MV3. |
oliverdunk
left a comment
oliverdunk
left a comment
There was a problem hiding this comment.
Left a few initial thoughts - thanks for your patience on this one!
jpmedley
left a comment
jpmedley
left a comment
There was a problem hiding this comment.
There isn't inherently anything wrong with what you wrote. The issue is that we need consistency for most of the changes I requested. It's no reasonable to expect a guest contributor to know that.
Co-authored-by: Joe Medley <jmedley@google.com>
|
READMEs and Descriptions: LGTM |
Co-authored-by: Joe Medley <jmedley@google.com>
jpmedley
left a comment
jpmedley
left a comment
There was a problem hiding this comment.
I stumbled on a typo when I was looking at where you replaced messages.json text with manifest.json text. I think I made the typo in one of my suggestions. Sorry about that.
|
Could you add the example for download open. I could not using it currently |
| suggest({ | ||
| filename: item.filename, | ||
| conflictAction: 'overwrite' | ||
| }); |
|
hi @daidr, I am really sorry this sat unreviewed for so long. appreciate you taking the time to send it in, but there were a few tweaks I had to make. I sent in #1716 with those changes, but they are stacked on top of these commits so history keeps you as the original author. closing this in favor of that one. thank you! |
6 participants
No description provided.