Fixing Temporal.Duration and Temporal.Instant usage in use cases and demos#732
Open
pattishin wants to merge 8 commits into
Open
Fixing Temporal.Duration and Temporal.Instant usage in use cases and demos#732pattishin wants to merge 8 commits into
pattishin wants to merge 8 commits into
Conversation
…leString() and update guide expectations
…ing card containers by adding word-break styling
Small formatting for stabilize-reactive-state
pattishin
requested review from
malchata,
philipwalton and
rviscomi
as code owners
Contributor
Author
|
Adding in changes based on comments from #376 - converting back to draft. |
Member
|
@pattishin will this be ready for review before launch? |
Contributor
Author
@rviscomi I can make it happen! I won't add in changes for #376 just yet. I'll ping when it's up! |
pattishin
commented
May 18, 2026
| } | ||
| prevDateStateValue = dateState.deadline; | ||
| } | ||
| dateValue.textContent = dateState.deadline.toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' }); |
Contributor
Author
There was a problem hiding this comment.
This was just formatting issues. No actual content modified.
Contributor
Author
|
@rviscomi Ready for review again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #374 , #375 , #377 (overall #79)
@sffc I believe I captured your comments from #374 and #375, but please let me know if any were overlooked!