add meta name text-scale guidance#759
Draft
patrickkettner wants to merge 2 commits into
Draft
Conversation
patrickkettner
requested review from
malchata,
philipwalton and
rviscomi
as code owners
Per the new use-case guide process, step 1 is just the stub guide.md frontmatter and a demo.html. Removes body of guide.md and expectations.md (belongs to step 2).
Member
|
This feature isn't a blocker for I/O, so I'm going to set this PR to draft. After I/O, but before marking it ready for review, could you add any other relevant use cases for the feature? Most features have between 2–5 use cases, but it's ok if there's truly just one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possibly fix #691
I was only able to get the unguided runs to pass 3/5 times, and that was with a decent amount of horseplay with the tasks to actively make them worse. By default it was passing 5/5 unguided.
Similar to #755, I was not sure if that meant we should reconsider the value of the topic for a guide.