Skip to content

Declarative button actions edits#795

Open
dvdherron wants to merge 6 commits into
mainfrom
declarative-button-actions-edits
Open

Declarative button actions edits#795
dvdherron wants to merge 6 commits into
mainfrom
declarative-button-actions-edits

Conversation

@dvdherron
Copy link
Copy Markdown
Contributor

Closes #331

  • Cleans up shape of inline polyfill
  • removes timing benefit for custom commands
  • consistent event delegation
  • make certain instructions more actionable (“It must have a unique id.” → “If it doesn’t have a unique id , add one”)
  • Consistent command registry approach
  • Rename to make it clear that this is about custom commands only (This was updated in a separate PR but I think it's along the same lines? Open to simplifying).

@dvdherron
Copy link
Copy Markdown
Contributor Author

@LeaVerou I know there's mention of splitting up/merging this guide. Wanted to do some cleanup beforehand in case we decide to keep this use case for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create guide and evals for the declarative-button-actions use case

1 participant