Skip to content

review edits: declarative dialog popover control#806

Merged
rviscomi merged 3 commits into
mainfrom
edits-declarative-dialog-popover-control
May 14, 2026
Merged

review edits: declarative dialog popover control#806
rviscomi merged 3 commits into
mainfrom
edits-declarative-dialog-popover-control

Conversation

@dvdherron
Copy link
Copy Markdown
Contributor

Closes #332

  • doesn't address the splitting of the guides
  • begins to add more specific ARIA guidance
  • the css issue was fixed in a previous PR
  • address the language around fallback usage
  • does not update graders/evals

@dvdherron
Copy link
Copy Markdown
Contributor Author

dvdherron commented May 13, 2026

@jamesnw I'm a little unsure about what specific guidance makes sense for ARIA usage in the invoker-polyfill fallback. There's a partially working implementation in the demo. See #795 for how it's handled for custom actions.

(Assigning you, just to keep an eye on this while I'm out)

@dvdherron dvdherron marked this pull request as ready for review May 13, 2026 20:12
@dvdherron dvdherron requested a review from LeaVerou May 13, 2026 20:13
Comment thread guides/user-experience/declarative-dialog-popover-control/guide.md
@rviscomi rviscomi merged commit fec7549 into main May 14, 2026
4 checks passed
@rviscomi rviscomi deleted the edits-declarative-dialog-popover-control branch May 14, 2026 19:24
@jamesnw jamesnw removed their assignment May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create guide and evals for the declarative-dialog-popover-control use case

4 participants