role alert has an implicit aria-live value of assertive#863
Merged
Conversation
Elements with the role alert have an implicit aria-live value of assertive, and an implicit aria-atomic value of true. https://www.w3.org/TR/wai-aria-1.2/#alert And I added a <button type="button"> as <button> is a submit and can cause form submissions when it is a descendant of <form> elements
BogdanCerovac
requested review from
malchata,
philipwalton and
rviscomi
as code owners
knowler
approved these changes
May 22, 2026
Member
|
Thanks @BogdanCerovac! And thanks @knowler for the review! |
rviscomi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements with the role alert have an implicit
aria-livevalue ofassertive, and an implicitaria-atomicvalue oftrue.So extra aria-live="assertive" is redundant and I suggest we remove it.
Spec: https://www.w3.org/TR/wai-aria-1.2/#alert
Added also
<button type="button">as<button>is a submit and can cause form submissions when it is a descendant of<form>elements.