diff --git a/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-chromium-linux.png b/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-chromium-linux.png index c9bd25f32..ff03cee6e 100644 Binary files a/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-chromium-linux.png and b/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-chromium-linux.png differ diff --git a/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-dark-chromium-linux.png b/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-dark-chromium-linux.png index 6a10d2af6..fdadc60d6 100644 Binary files a/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-dark-chromium-linux.png and b/e2e/tests/404.spec.ts-snapshots/not-found-error-page-similar-results-dark-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-chromium-linux.png index 0407d3eb9..53982a5dd 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-chromium-linux.png index 99af88520..6337b0b52 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-firefox-linux.png index 09b2b5cc3..8707a041e 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-webkit-linux.png index 4ec6d5962..2ad645a4b 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-dark-webkit-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-chromium-linux.png index 80b10ad95..8c9453f5c 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-chromium-linux.png index 07b59e759..ce197e20a 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-firefox-linux.png index 2e4d7c054..fe7d2d84a 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-webkit-linux.png index 142b5ceb4..f5f051aa4 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-dark-webkit-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-firefox-linux.png index b04c92cca..cd3d6242d 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-webkit-linux.png index be0823551..b10dd9ef0 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-discouraged-webkit-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-firefox-linux.png index bd2f51127..a399e75a7 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-chromium-linux.png index 3778e3ee7..80715b35a 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-chromium-linux.png index 8716fd290..2d0def697 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-firefox-linux.png index c403af068..39981f23a 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-webkit-linux.png index cf808a79b..9e8acab3f 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-dark-webkit-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-firefox-linux.png index b3746c8d4..79a15daf6 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-webkit-linux.png index c75390dde..8b7f38a8a 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-mobile-webkit-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-chromium-linux.png index 02c261792..ae8a663bd 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-chromium-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-chromium-linux.png index f0fe41716..95e0c11e8 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-chromium-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-chromium-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-firefox-linux.png index 83a9d7575..f52388795 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-dark-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-firefox-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-firefox-linux.png index 236a214ee..0de3dc7e9 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-firefox-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-redirect-firefox-linux.png differ diff --git a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-webkit-linux.png b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-webkit-linux.png index fc11ad0eb..8233573c5 100644 Binary files a/e2e/tests/feature-page.spec.ts-snapshots/feature-page-webkit-linux.png and b/e2e/tests/feature-page.spec.ts-snapshots/feature-page-webkit-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-chromium-linux.png index 61aa36fb6..c0da3474d 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-chromium-linux.png index efa18d32f..87f213a7c 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-firefox-linux.png index e262707b6..0b9029ebf 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-dark-firefox-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-firefox-linux.png index 0749ed4f3..75539d92b 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-firefox-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-chromium-linux.png index c411b38e8..eea8b6673 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-chromium-linux.png index 420f05bed..55089004b 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-firefox-linux.png index c5108b6de..ef1daf655 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-dark-firefox-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-firefox-linux.png index de90d0c8e..6c17501f2 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-mobile-firefox-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-chromium-linux.png index 233f29110..a4dad7e93 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-chromium-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-chromium-linux.png index 3a8bf5f56..944851f6d 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-chromium-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-chromium-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-firefox-linux.png index 66960ac13..655bb646a 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-dark-firefox-linux.png differ diff --git a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-firefox-linux.png b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-firefox-linux.png index 07167b6a6..b94c4a1d2 100644 Binary files a/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-firefox-linux.png and b/e2e/tests/overview-page.spec.ts-snapshots/overview-page-sort-firefox-linux.png differ diff --git a/frontend/src/static/js/components/test/webstatus-feature-page.test.ts b/frontend/src/static/js/components/test/webstatus-feature-page.test.ts index 2504ff2bb..4766646f1 100644 --- a/frontend/src/static/js/components/test/webstatus-feature-page.test.ts +++ b/frontend/src/static/js/components/test/webstatus-feature-page.test.ts @@ -18,7 +18,6 @@ import {expect, fixture, html} from '@open-wc/testing'; import {FeaturePage} from '../webstatus-feature-page.js'; import '../webstatus-feature-page.js'; import sinon from 'sinon'; -import {WPTRunMetric} from '../../api/client.js'; import {render} from 'lit'; import {FeatureMovedError} from '../../api/errors.js'; @@ -175,109 +174,7 @@ describe('webstatus-feature-page', () => { expect(descriptionSection).to.not.be.null; expect(descriptionSection?.textContent).to.contain('AMAZING DESCRIPTION'); }); - describe('renderDeltaChip', () => { - let element: FeaturePage; - let hostElement: HTMLDivElement; - - beforeEach(async () => { - element = await fixture( - html``, - ); - hostElement = document.createElement('div'); - // Create a new Map for featureSupport - element.featureSupport = new Map>([ - // increase case - [ - 'chrome', - [ - { - test_pass_count: 90, - total_tests_count: 100, - run_timestamp: '2023-12-27T01:28:25.177Z', - }, - { - test_pass_count: 85, - total_tests_count: 100, - run_timestamp: '2023-12-26T01:28:07.225Z', - }, - ], - ], - // decrease case - [ - 'edge', - [ - { - test_pass_count: 70, - total_tests_count: 100, - run_timestamp: '2023-12-27T01:28:25.177Z', - }, - { - test_pass_count: 75, - total_tests_count: 100, - run_timestamp: '2023-12-26T01:28:07.225Z', - }, - ], - ], - // no changes case - [ - 'safari', - [ - { - test_pass_count: 80, - total_tests_count: 100, - run_timestamp: '2023-12-27T01:28:25.177Z', - }, - { - test_pass_count: 80, - total_tests_count: 100, - run_timestamp: '2023-12-26T01:28:07.225Z', - }, - ], - ], - // firefox will be the no runs case - ]); - await element.updateComplete; - }); - - it('renders unchanged chip when there are no runs', async () => { - const chipTemplate = element.renderDeltaChip('firefox'); - render(chipTemplate, hostElement); - const host = await fixture(hostElement); - const chip = host.querySelector('span'); - expect(chip?.classList.contains('unchanged')).to.be.true; - expect(chip?.textContent).to.equal(''); - }); - - it('renders chip with positive delta and increased class', async () => { - const chipTemplate = element.renderDeltaChip('chrome'); - render(chipTemplate, hostElement); - const host = await fixture(hostElement); - const chip = host.querySelector('span'); - expect(chip?.classList.contains('increased')).to.be.true; - expect(chip?.textContent).to.equal('+5.0%'); - }); - - it('renders chip with negative delta and decreased class', async () => { - const chipTemplate = element.renderDeltaChip('edge'); - render(chipTemplate, hostElement); - const host = await fixture(hostElement); - const chip = host.querySelector('span'); - expect(chip?.classList.contains('decreased')).to.be.true; - expect(chip?.textContent).to.equal('-5.0%'); - }); - - it('renders chip with no delta and unchanged class', async () => { - const chipTemplate = element.renderDeltaChip('safari'); - render(chipTemplate, hostElement); - const host = await fixture(hostElement); - const chip = host.querySelector('span'); - expect(chip?.classList.contains('unchanged')).to.be.true; - expect(chip?.textContent).to.equal('0.0%'); - }); - }); describe('renderBrowserImpl', () => { let element: FeaturePage; let hostElement: HTMLDivElement; diff --git a/frontend/src/static/js/components/webstatus-feature-page.ts b/frontend/src/static/js/components/webstatus-feature-page.ts index 068964f6e..64f28a236 100644 --- a/frontend/src/static/js/components/webstatus-feature-page.ts +++ b/frontend/src/static/js/components/webstatus-feature-page.ts @@ -167,18 +167,6 @@ export class FeaturePage extends BaseChartsPage { gap: var(--content-padding-half); align-items: center; } - .chip.increased { - background: var(--chip-background-increased); - color: var(--chip-color-increased); - } - .chip.unchanged { - background: var(--chip-background-unchanged); - color: var(--chip-color-unchanged); - } - .chip.decreased { - background: var(--chip-background-decreased); - color: var(--chip-color-decreased); - } baseline-date { font-size: 0.8em; @@ -537,35 +525,6 @@ export class FeaturePage extends BaseChartsPage { `; } - renderDeltaChip( - browser: components['parameters']['browserPathParam'], - ): TemplateResult { - const runs = this.featureSupport.get(browser); - if (runs === undefined || runs.length === 0) { - return html` `; - } - - // Runs are retrieved in descending chronological order. - const mostRecentRun = runs[0]; - const oldestRun = runs[runs.length - 1]; - const mostRecentPercent = - mostRecentRun.test_pass_count! / mostRecentRun.total_tests_count!; - const oldestPercent = - oldestRun.test_pass_count! / oldestRun.total_tests_count!; - const delta = (mostRecentPercent - oldestPercent) * 100.0; - let deltaStr = Number(delta).toFixed(1) + '%'; - let deltaClass = 'unchanged'; - if (delta > 0) { - deltaStr = '+' + deltaStr; - deltaClass = 'increased'; - } else if (delta < 0) { - deltaClass = 'decreased'; - } else { - deltaClass = 'unchanged'; - } - return html` ${deltaStr} `; - } - renderBrowserImpl( browserImpl?: components['schemas']['BrowserImplementation'], ): TemplateResult { @@ -591,7 +550,11 @@ export class FeaturePage extends BaseChartsPage { icon: string, ): TemplateResult { const scorePart = this.feature - ? renderBrowserQuality(this.feature, {search: ''}, {browser: browser}) + ? renderBrowserQuality( + this.feature, + {search: ''}, + {browser: browser, fallbackText: 'N/A'}, + ) : html``; const browserImpl = this.feature?.browser_implementations?.[browser]; @@ -599,7 +562,7 @@ export class FeaturePage extends BaseChartsPage {
${BROWSER_ID_TO_LABEL[browser]}
-
${scorePart} ${this.renderDeltaChip(browser)}
+
${scorePart}
${this.renderBrowserImpl(browserImpl)} `; diff --git a/frontend/src/static/js/components/webstatus-overview-cells.ts b/frontend/src/static/js/components/webstatus-overview-cells.ts index a6ab68626..46e95fac2 100644 --- a/frontend/src/static/js/components/webstatus-overview-cells.ts +++ b/frontend/src/static/js/components/webstatus-overview-cells.ts @@ -31,8 +31,6 @@ import './webstatus-feature-badge.js'; import {formatDeveloperUpvotesMessages} from '../utils/format.js'; import {VendorPositions} from '../utils/vendor-position.js'; -const MISSING_VALUE = html``; - type CellRenderer = { ( feature: components['schemas']['Feature'], @@ -41,6 +39,7 @@ type CellRenderer = { browser?: components['parameters']['browserPathParam']; channel?: components['parameters']['channelPathParam']; platform?: string; + fallbackText?: string; }, ): TemplateResult | typeof nothing; }; @@ -445,7 +444,7 @@ export const renderAvailablity: CellRenderer = ( }; function renderMissingPercentage(): TemplateResult { - return html`${MISSING_VALUE}`; + return html``; } function renderPercentage(score?: number): TemplateResult { @@ -462,14 +461,16 @@ function renderPercentage(score?: number): TemplateResult { export const renderBrowserQuality: CellRenderer = ( feature, _routerLocation, - {browser}, + {browser, fallbackText}, ) => { const score: number | undefined = feature.wpt?.stable?.[browser!]?.score; let percentage = renderPercentage(score); const browserImpl = feature.browser_implementations?.[browser!]; const browserImplStatus = browserImpl?.status || 'unavailable'; - if (browserImplStatus === 'unavailable') { - percentage = renderMissingPercentage(); + if (browserImplStatus === 'unavailable' || score === undefined) { + percentage = fallbackText + ? html`${fallbackText}` + : renderMissingPercentage(); } if (feature.spec && isJavaScriptFeature(feature.spec)) { percentage = renderJavaScriptFeatureValue();