Fix: guard against null line_model in distance.element position setter#692
Open
xianjianlf2 wants to merge 1 commit into
Open
Fix: guard against null line_model in distance.element position setter#692xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
The position setter passed line_model straight to the styleProps setter and render(), both of which destructure it. When line_model is null or undefined (e.g. during rapid mouse movement or when measured elements unmount in SPAs), this threw a TypeError. Bail out early when line_model is falsy. Fixes GoogleChromeLabs#686
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #686.
The
positionsetter inapp/components/selection/distance.element.jspassedline_modeldirectly into thestylePropssetter andrender(), both of which destructure it ({y, x, d, q, v, color}and{q, d}respectively).When
line_modelisnullorundefined— which can happen during rapid mouse movement or when measured elements dynamically unmount in single-page apps — destructuring throws aTypeErrorand crashes the measurement overlay.Change
Add an early-return guard at the top of the
positionsetter so a falsyline_modelis ignored instead of crashing:Minimal, no behavior change for valid input.