Merge pull request #938 from GoogleChromeLabs/password-spaces-fix

Wrapping keystore passwords in quotes to allow spaces (fixes #936)

Author: OlegNitz

packages/cli/src/lib/cmds/build.ts

@@ -111,9 +111,9 @@ class Build {
   async signApk(signingKey: SigningKeyInfo, passwords: SigningKeyPasswords): Promise<void> {
     await this.androidSdkTools.apksigner(
         signingKey.path,
-        passwords.keystorePassword,
+        `"${passwords.keystorePassword}"`,
         signingKey.alias,
-        passwords.keyPassword,
+        `"${passwords.keyPassword}"`,
         APK_ALIGNED_FILE_NAME, // input file path
         APK_SIGNED_FILE_NAME,
     );
@@ -124,8 +124,12 @@ class Build {
   }
 
   async signAppBundle(signingKey: SigningKeyInfo, passwords: SigningKeyPasswords): Promise<void> {
-    await this.jarSigner.sign(signingKey, passwords.keystorePassword, passwords.keyPassword,
-        APP_BUNDLE_BUILD_OUTPUT_FILE_NAME, APP_BUNDLE_SIGNED_FILE_NAME);
+    await this.jarSigner.sign(
+        signingKey,
+        `"${passwords.keystorePassword}"`,
+        `"${passwords.keyPassword}"`,
+        APP_BUNDLE_BUILD_OUTPUT_FILE_NAME,
+        APP_BUNDLE_SIGNED_FILE_NAME);
   }
 
   /**