Skip to content

fix(cli): use single quote to prevent bash expansion #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mongj wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cli): use single quote to prevent bash expansion #982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0b9e3
fix: use single quote to prevent bash expansion
mongj Dec 6, 2025
2d780c5
fix: escape single quotes
mongj Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/cli/src/lib/cmds/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ class Build {
};
}

formatPassword(password: string): string {
return `'${password}'`.replace(/'/g, "'\\''");
}

async buildApk(): Promise<void> {
await this.gradleWrapper.assembleRelease();
await this.androidSdkTools.zipalignOnlyVerification(
Expand All @@ -111,9 +115,9 @@ class Build {
async signApk(signingKey: SigningKeyInfo, passwords: SigningKeyPasswords): Promise<void> {
await this.androidSdkTools.apksigner(
signingKey.path,
`"${passwords.keystorePassword}"`,
this.formatPassword(passwords.keystorePassword),
signingKey.alias,
`"${passwords.keyPassword}"`,
this.formatPassword(passwords.keyPassword),
APK_ALIGNED_FILE_NAME, // input file path
APK_SIGNED_FILE_NAME,
);
Expand All @@ -126,8 +130,8 @@ class Build {
async signAppBundle(signingKey: SigningKeyInfo, passwords: SigningKeyPasswords): Promise<void> {
await this.jarSigner.sign(
signingKey,
`"${passwords.keystorePassword}"`,
`"${passwords.keyPassword}"`,
this.formatPassword(passwords.keystorePassword),
this.formatPassword(passwords.keyPassword),
APP_BUNDLE_BUILD_OUTPUT_FILE_NAME,
APP_BUNDLE_SIGNED_FILE_NAME);
}
Expand Down