This repository was archived by the owner on Jan 21, 2021. It is now read-only.
Added option for excluding named chunks#61
Open
gunhaxxor wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Open
Added option for excluding named chunks#61gunhaxxor wants to merge 1 commit intoGoogleChromeLabs:masterfrom
gunhaxxor wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's very important to be able to exclude specific chunks from the prefetch. A common use case is a chunk handling the admin route in the web app which might expose a security vulnurability if fetched by all clients.
I added functionality for providing an array with named chunks that should get excluded from the plugin.