Skip to content

tests: mock external requests#464

Merged
XhmikosR merged 1 commit into
mainfrom
xmr/tests
May 22, 2026
Merged

tests: mock external requests#464
XhmikosR merged 1 commit into
mainfrom
xmr/tests

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Dec 6, 2025

Copy link
Copy Markdown
Collaborator

@addyosmani WDYT? This should help with the tests flakiness since we no longer depend on external URLs.

Note that I used AI to help out.

@XhmikosR XhmikosR force-pushed the xmr/tests branch 2 times, most recently from 5ad5acf to 1250d45 Compare December 8, 2025 07:39
@XhmikosR XhmikosR added the squash Squash PR label Dec 8, 2025
@XhmikosR XhmikosR marked this pull request as ready for review December 8, 2025 07:41
@XhmikosR XhmikosR requested a review from addyosmani January 17, 2026 19:23
@XhmikosR XhmikosR force-pushed the xmr/tests branch 4 times, most recently from 148e27d to b51fe09 Compare February 8, 2026 20:03
@XhmikosR XhmikosR force-pushed the xmr/tests branch 2 times, most recently from cf0753f to d18b56d Compare May 21, 2026 06:07
@XhmikosR

Copy link
Copy Markdown
Collaborator Author

/CC @addyosmani WDYT?

@XhmikosR

Copy link
Copy Markdown
Collaborator Author

I'm going to merge this @addyosmani but I'd appreciate if you could look at the other PRs.

@XhmikosR XhmikosR merged commit 5b4fc24 into main May 22, 2026
11 checks passed
@XhmikosR XhmikosR deleted the xmr/tests branch May 22, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squash Squash PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant