Skip to content

Update ESLint to v9 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addyosmani merged 3 commits into from
Jun 13, 2026
Merged

Update ESLint to v9 #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0508078
Update ESLint to v9
XhmikosR Dec 6, 2025
8a45bb0
Update network-idle.js
XhmikosR Jun 11, 2026
c70c2d8
Update network-idle.js
XhmikosR Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .eslintignore
View file
Open in desktop

This file was deleted.

100 changes: 0 additions & 100 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions demos/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-env serviceworker */

'use strict';

importScripts('https://unpkg.com/network-idle-callback@1.0.1/lib/request-monitor.js');
Expand Down
152 changes: 152 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
const {fixupConfigRules, fixupPluginRules} = require('@eslint/compat');
const globals = require('globals');
const googleConfig = require('eslint-config-google');
const jsdocPlugin = require('eslint-plugin-jsdoc');
const reactPlugin = require('eslint-plugin-react');

const jsdocRecommended = jsdocPlugin.configs['flat/recommended'] || jsdocPlugin.configs.recommended;

const [reactRecommended] = fixupConfigRules(reactPlugin.configs.recommended);
const googleRules = {
...googleConfig.rules,
};
delete googleRules['valid-jsdoc'];
delete googleRules['require-jsdoc'];

module.exports = [
{
ignores: [
'**/*.min.js',
'**/dist/',
'**/build/',
'**/vendor/',
'eslint.config.js',
],
},
{
name: 'quicklink/base',
languageOptions: {
ecmaVersion: 2017,
sourceType: 'script',
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
globals: {
...globals.browser,
...globals.node,
},
},
plugins: {
react: fixupPluginRules(reactPlugin),
},
settings: {
react: {
version: 'detect',
},
},
rules: {
...(reactRecommended?.rules ?? reactPlugin.configs.recommended.rules),
...googleRules,
'max-len': [
'warn',
{
code: 130,
},
],
'arrow-parens': [
'error',
'as-needed',
],
'space-before-function-paren': [
'error',
{
anonymous: 'always',
named: 'never',
},
],
'no-negated-condition': 'warn',
'no-const-assign': 'error',
'no-unused-vars': [
'error',
{
args: 'none',
varsIgnorePattern: '^_',
caughtErrorsIgnorePattern: '^_',
},
],
'prefer-destructuring': [
'off',
{
object: true,
array: false,
},
],
'prefer-template': 'error',
strict: [
'error',
'global',
],
'spaced-comment': [
'error',
'always',
{
exceptions: [
'/',
],
},
],
},
},
{
files: [
'src/**',
],
languageOptions: {
sourceType: 'module',
},
rules: {
strict: [
'error',
'never',
],
},
},
...(Array.isArray(jsdocRecommended) ? jsdocRecommended : [jsdocRecommended]),
{
files: [
'site/src/assets/js/**',
],
languageOptions: {
sourceType: 'script',
globals: {
...globals.browser,
},
},
rules: {
'jsdoc/require-jsdoc': 'off',
strict: [
'error',
'function',
],
},
},
{
files: [
'site/src/demos/**',
],
languageOptions: {
sourceType: 'module',
ecmaVersion: 2020,
globals: {
...globals.browser,
},
},
rules: {
'jsdoc/require-jsdoc': 'off',
'strict': ['error', 'never'],
'max-len': 'off',
},
},
];
Loading