Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

minValue not behaving as expected? #12

@gabe-lyons

Description

@gabe-lyons

In the documentation minValue is described as "The lower bound to start forward-searching for the quiet window. If no value is set, the default is after the DOMContentLoaded event."

Looking at the code, it seems like the only time minValue is used is in the return value of computeFirstConsistentlyInteractive:

return Math.max(maybeFCI, minValue);

Then that value is immediately resolved:

In this case it seems like the forward-searching for the quiet window happens first, and then the evaluated tti is just compared with minValue at the end. Am I missing something? Ideally I would like a minValue parameter that behaved as per the description. A motivating example would be measuring tti on a client-side route, where a batch of activity would occur well after the initial page load.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions