Commit 094ef7d
committed
Address second review: autoformat scripts/, new findings, polish
B1: Add scripts/ to autoformat.sh scope; run pyink+isort on both
scripts (now consistent 2-space indent throughout)
N1: Guard --sdk-tree + --output-json - (SDK trace.render() writes
directly to stdout, bypassing the stderr routing)
N4: Add test_cache_isolates_paths — proves two different config paths
return two different configs (regression guard for B2 fix)
N5: Include session ID in A2A JSON parse warning for debuggability
M2: Add docstring to get_eval_metrics documenting returned metrics
and the always-present declined category
M8: Qualify run_eval.py path in --session-ids-file help text
N3: Add --env example to README direct-Python usage section
L4: Complete latency_report.py module docstring with all flags
(--no-waterfall, --sdk-tree, --report, --output-json, --env)
79 tests pass, autoformat clean (pyink + isort).1 parent 5dcc527 commit 094ef7d
5 files changed
Lines changed: 762 additions & 602 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| 196 | + | |
196 | 197 | | |
197 | 198 | | |
198 | 199 | | |
| |||
0 commit comments