Skip to content

Commit 094ef7d

Browse files
committed
Address second review: autoformat scripts/, new findings, polish
B1: Add scripts/ to autoformat.sh scope; run pyink+isort on both scripts (now consistent 2-space indent throughout) N1: Guard --sdk-tree + --output-json - (SDK trace.render() writes directly to stdout, bypassing the stderr routing) N4: Add test_cache_isolates_paths — proves two different config paths return two different configs (regression guard for B2 fix) N5: Include session ID in A2A JSON parse warning for debuggability M2: Add docstring to get_eval_metrics documenting returned metrics and the always-present declined category M8: Qualify run_eval.py path in --session-ids-file help text N3: Add --env example to README direct-Python usage section L4: Complete latency_report.py module docstring with all flags (--no-waterfall, --sdk-tree, --report, --output-json, --env) 79 tests pass, autoformat clean (pyink + isort).
1 parent 5dcc527 commit 094ef7d

5 files changed

Lines changed: 762 additions & 602 deletions

File tree

autoformat.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ set -euo pipefail
2121
REPO_ROOT="$(cd "$(dirname "$0")" && pwd)"
2222

2323
echo "==> Running isort (import sorting)..."
24-
isort "${REPO_ROOT}/src/" "${REPO_ROOT}/tests/" "${REPO_ROOT}/examples/"
24+
isort "${REPO_ROOT}/src/" "${REPO_ROOT}/tests/" "${REPO_ROOT}/examples/" "${REPO_ROOT}/scripts/"
2525

2626
echo "==> Running pyink (code formatting)..."
27-
pyink --config "${REPO_ROOT}/pyproject.toml" "${REPO_ROOT}/src/" "${REPO_ROOT}/tests/" "${REPO_ROOT}/examples/"
27+
pyink --config "${REPO_ROOT}/pyproject.toml" "${REPO_ROOT}/src/" "${REPO_ROOT}/tests/" "${REPO_ROOT}/examples/" "${REPO_ROOT}/scripts/"
2828

2929
echo "==> Done. All Python files formatted."

scripts/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ Or run the Python script directly:
193193

194194
```bash
195195
python scripts/latency_report.py --limit 5 --time-period 1h
196+
python scripts/latency_report.py --env path/to/.env --limit 5
196197
```
197198

198199
### Output

0 commit comments

Comments
 (0)