fix(release): deviating guard message — reject the rebuilt attempt, burn only vs the original anchor (#353)#369
Merged
haiyuan-eng-google merged 2 commits intoJul 15, 2026
Conversation
This was referenced Jul 15, 2026
…inal run before asserting a burn (GoogleCloudPlatform#353) A deviation from THIS attempt's rebuilt bytes does not by itself burn the version: an accidental full rerun is rejected, and the operator is directed back to the ORIGINAL workflow attempt whose preserved artifact matches what the index accepted. The burn clause is scoped to a deviation from the ORIGINAL accepted anchor (which finalize reports as a burn state). Tests assert the message shape and ordering (original-run direction before the burn clause).
…explicitly (GoogleCloudPlatform#353 review round 2) The guard's inputs cannot distinguish a first-attempt index conflict from a full rerun, so the message now states both branches: on the ORIGINAL workflow attempt the current distributions ARE the original workflow build anchor and pre-existing/conflicting index files burn the version outright (finalize cannot classify that run — github-release fails at this guard); on a full rerun the mismatch proves only that the rebuilt attempt must be abandoned in favor of the recoverable original run. 'original accepted anchor' wording replaced with 'original workflow build anchor'; regressions pin BOTH interpretations.
caohy1988
force-pushed
the
fix/353-guard-deviating-message
branch
from
July 15, 2026 22:00
12c8ab4 to
4d56520
Compare
haiyuan-eng-google
approved these changes
Jul 15, 2026
haiyuan-eng-google
merged commit Jul 15, 2026
7cd8401
into
GoogleCloudPlatform:main
23 checks passed
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code/test follow-up requested in the #353 operational reviews: the guard's
deviatingmessage previously said "the version is burned there" for any mismatch against the current attempt's bytes, which mislabeled an accidental full rerun as a burn — and its first fix wrongly claimedfinalizewould report the burn state.The message now states BOTH interpretations of the same guard inputs explicitly:
finalizecannot classify that run:github-releasefails at this guard andfinalizeis gated on its success (the docstring documents this).Two regressions pin the two interpretations (
test_deviating_message_states_the_first_attempt_burn_branch— including an assertion that the removed "accepted anchor" wording never reappears — andtest_deviating_message_states_the_full_rerun_reject_branch). Full producer suite: 547 passed, 4 skipped.Status: rebased onto post-#367
main; head4d56520descends directly from the #367 merge (96a079f). All 19 checks pass (Hash-lock drift included) plus the four expected conditional zizmor skips. Blocked only on required review.Part of #353.