Skip to content

Commit 9c7379d

Browse files
author
Aditya Bharadwaj
committed
removed oracle fixes
1 parent 1ca6772 commit 9c7379d

5 files changed

Lines changed: 10 additions & 37 deletions

File tree

v2/datastream-to-spanner/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@
109109
<artifactId>google-cloud-compute</artifactId>
110110
<scope>test</scope>
111111
</dependency>
112-
113112
</dependencies>
114113

115114
<profiles>

v2/datastream-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/datastream/source/mysql/MySqlSourceConnector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ public Map<String, Pair<String, String>> getSortOrder(Dialect dialect) {
5656
public ChangeEventContext createChangeEventContext(
5757
JsonNode changeEvent, Ddl ddl, Ddl shadowTableDdl, String shadowTablePrefix)
5858
throws ChangeEventConvertorException, InvalidChangeEventException, DroppedTableException {
59-
return new MySqlChangeEventContext(
60-
changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
59+
return new MySqlChangeEventContext(changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
6160
}
6261

6362
@Override

v2/datastream-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/datastream/source/oracle/OracleSourceConnector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ public Map<String, Pair<String, String>> getSortOrder(Dialect dialect) {
5656
public ChangeEventContext createChangeEventContext(
5757
JsonNode changeEvent, Ddl ddl, Ddl shadowTableDdl, String shadowTablePrefix)
5858
throws ChangeEventConvertorException, InvalidChangeEventException, DroppedTableException {
59-
return new OracleChangeEventContext(
60-
changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
59+
return new OracleChangeEventContext(changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
6160
}
6261

6362
@Override

v2/datastream-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/datastream/source/postgresql/PostgresqlSourceConnector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ public Map<String, Pair<String, String>> getSortOrder(Dialect dialect) {
5656
public ChangeEventContext createChangeEventContext(
5757
JsonNode changeEvent, Ddl ddl, Ddl shadowTableDdl, String shadowTablePrefix)
5858
throws ChangeEventConvertorException, InvalidChangeEventException, DroppedTableException {
59-
return new PostgresChangeEventContext(
60-
changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
59+
return new PostgresChangeEventContext(changeEvent, ddl, shadowTableDdl, shadowTablePrefix);
6160
}
6261

6362
@Override

v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/DataStreamToSpannerIT.java

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ public void testDataStreamMySqlToSpanner() throws IOException {
141141
}
142142

143143
@Test
144+
@Ignore("This test is flaky, and Oracle is not fully supported migration source yet")
144145
public void testDataStreamOracleToSpanner() throws IOException {
145146
// Run a simple IT
146147
simpleOracleToSpannerTest(
@@ -177,6 +178,7 @@ public void testDataStreamMySqlToSpannerJson() throws IOException {
177178
}
178179

179180
@Test
181+
@Ignore("This test is flaky, and Oracle is not fully supported migration source yet")
180182
public void testDataStreamOracleToSpannerJson() throws IOException {
181183
// Run a simple IT
182184
simpleOracleToSpannerTest(
@@ -209,14 +211,7 @@ private void simpleOracleToSpannerTest(
209211
throws IOException {
210212

211213
simpleJdbcToSpannerTest(
212-
JDBCType.ORACLE,
213-
fileFormat,
214-
spannerDialect,
215-
config ->
216-
paramsAdder.apply(
217-
config.addParameter(
218-
"sessionFilePath",
219-
getGcsPath("input/oracle-session.json", gcsResourceManager))));
214+
JDBCType.ORACLE, fileFormat, spannerDialect, config -> paramsAdder.apply(config));
220215
}
221216

222217
private void simpleJdbcToSpannerTest(
@@ -251,18 +246,9 @@ private void simpleJdbcToSpannerTest(
251246
gcsResourceManager.createArtifact(
252247
"input/mysql-session.json",
253248
generateSessionFile(
254-
"mysql",
255249
cloudSqlResourceManager.getDatabaseName(),
256250
spannerResourceManager.getDatabaseId(),
257251
tableNames));
258-
} else if (jdbcType.equals(JDBCType.ORACLE)) {
259-
gcsResourceManager.createArtifact(
260-
"input/oracle-session.json",
261-
generateSessionFile(
262-
"oracle",
263-
cloudSqlResourceManager.getUsername().toUpperCase(),
264-
spannerResourceManager.getDatabaseId(),
265-
tableNames));
266252
}
267253

268254
// Create JDBC tables
@@ -372,23 +358,14 @@ private void simpleJdbcToSpannerTest(
372358
assertThatResult(result).meetsConditions();
373359
}
374360

375-
private String generateSessionFile(
376-
String databaseType, String srcDb, String spannerDb, List<String> tableNames)
361+
private String generateSessionFile(String srcDb, String spannerDb, List<String> tableNames)
377362
throws IOException {
378-
String sessionTemplate =
379-
databaseType.equals("mysql") ? "mysql-session.json" : "oracle-session.json";
380363
String sessionFile =
381364
Files.readString(
382-
Paths.get(Resources.getResource("DataStreamToSpannerIT/" + sessionTemplate).getPath()));
383-
sessionFile =
384-
sessionFile.replaceAll("SRC_DATABASE", srcDb).replaceAll("SP_DATABASE", spannerDb);
385-
if (databaseType.equals("oracle")) {
386-
sessionFile =
387-
sessionFile
388-
.replaceAll("TABLE1_UPPER", tableNames.get(0).toUpperCase())
389-
.replaceAll("TABLE2_UPPER", tableNames.get(1).toUpperCase());
390-
}
365+
Paths.get(Resources.getResource("DataStreamToSpannerIT/mysql-session.json").getPath()));
391366
return sessionFile
367+
.replaceAll("SRC_DATABASE", srcDb)
368+
.replaceAll("SP_DATABASE", spannerDb)
392369
.replaceAll("TABLE1", tableNames.get(0))
393370
.replaceAll("TABLE2", tableNames.get(1));
394371
}

0 commit comments

Comments
 (0)