try updating pr3369

[derrickaw]

1. Issue with build(deps): bump maven.version from 3.9.9 to 3.9.12 #3369 is that the cicd environment is using a different maven version than the one we are upgrading.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the core Maven version used within the project's templates-maven-plugin to a more recent release. Concurrently, it enhances the continuous integration setup by implementing a dynamic Maven installation process within the setup-env GitHub Action. This ensures that the CI environment always uses the exact Maven version declared in the project's pom.xml, improving build reliability and consistency.

Highlights

• Maven Version Update: The Maven version used by the templates-maven-plugin has been updated from 3.9.9 to 3.9.14.
• Dynamic Maven Installation in CI: The GitHub Action setup-env/action.yml was modified to dynamically fetch and install the Maven version specified in the project's pom.xml, ensuring consistency between the project configuration and the CI environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.32%. Comparing base (13953d7) to head (07e22f9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #3642       +/-   ##
=============================================
+ Coverage     32.89%   52.32%   +19.42%     
- Complexity      461     6156     +5695     
=============================================
  Files           214     1054      +840     
  Lines         12765    63624    +50859     
  Branches       1253     6997     +5744     
=============================================
+ Hits           4199    33289    +29090     
- Misses         8229    28075    +19846     
- Partials        337     2260     +1923     

Components	Coverage Δ
spanner-templates	72.16% <ø> (∅)
spanner-import-export	68.90% <ø> (∅)
spanner-live-forward-migration	80.44% <ø> (∅)
spanner-live-reverse-replication	77.83% <ø> (∅)
spanner-bulk-migration	89.19% <ø> (∅)
gcs-spanner-dv	85.38% <ø> (∅)
see 862 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Abacn]

maven is pre-installed in

DataflowTemplates/.github/scripts/startup-script.sh

Line 38 in afbc8a7

MAVEN_VER=3.9.9

We do not need to upgrade maven version often. If needed, consider go through the documented process here: https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/contributor-docs/cicd.md to provision new runners

[derrickaw]

Closing as upgrading maven version impacts runners via startup script etc and will require many manual steps to get everything back up and running.