Skip to content

Add Iceberg to AlloyDB YAML template#3932

Open
ihebimad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/iceberg-to-alloydb
Open

Add Iceberg to AlloyDB YAML template#3932
ihebimad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/iceberg-to-alloydb

Conversation

@ihebimad

@ihebimad ihebimad commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Successful IT JobID : 2026-06-19_09_54_35-1302943962825921393

@gemini-code-assist

gemini-code-assist Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new YAML-based Dataflow template designed to facilitate batch data migration from Apache Iceberg tables to AlloyDB. The changes include the core template definition, parameter configurations, documentation, and a robust integration test to ensure reliability.

Highlights

  • New Template Addition: Added a new YAML-based Dataflow template for migrating data from Apache Iceberg tables to AlloyDB.
  • Configuration and Documentation: Included necessary configuration files, documentation, and parameter definitions to support the new Iceberg to AlloyDB pipeline.
  • Integration Testing: Implemented a comprehensive integration test suite to verify the end-to-end functionality of the new template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the "Iceberg to AlloyDB (YAML)" batch pipeline template, including its Java metadata interface, YAML pipeline definition, configuration options, documentation, and integration tests. The review feedback identifies several critical issues: syntax errors in the YAML template's filesToCopy and requirements properties, the need to make the alloydbTable parameter mandatory rather than optional, the removal of the unused and unsupported query parameter across the interface and configurations, and a correction to the Terraform directory path in the README.

Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToAlloyDBYaml.java
Comment thread yaml/src/main/python/options/alloydb_options.yaml
Comment thread yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToAlloyDBYaml.java
Comment thread yaml/src/main/python/options/alloydb_options.yaml
Comment thread yaml/README_Iceberg_To_AlloyDB_Yaml.md Outdated
@derrickaw derrickaw added the addition New feature or request label Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.10%. Comparing base (af9d406) to head (f3084fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3932      +/-   ##
============================================
+ Coverage     35.52%   38.10%   +2.57%     
+ Complexity      697      512     -185     
============================================
  Files           250      195      -55     
  Lines         17031    11745    -5286     
  Branches       1721     1173     -548     
============================================
- Hits           6051     4475    -1576     
+ Misses        10474     6908    -3566     
+ Partials        506      362     -144
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 61 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ihebimad ihebimad force-pushed the feature/iceberg-to-alloydb branch from ced8d7f to 94057d0 Compare June 23, 2026 15:33
@derrickaw

derrickaw commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @ihebimad, i think our old template still uses 2025 copyright.

I opened a PR to fix - #3940

Up to you if you want to wait until the PR is merged or not.

@ihebimad ihebimad force-pushed the feature/iceberg-to-alloydb branch from 94057d0 to 5ad68f5 Compare June 23, 2026 15:58
@derrickaw

derrickaw commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Hi @ihebimad, #3940 is merged. Please rebase or merge. Thanks.

@ihebimad ihebimad force-pushed the feature/iceberg-to-alloydb branch from 5ad68f5 to f3084fb Compare June 24, 2026 08:05
@derrickaw

derrickaw commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

LGTM; @tarun-google any comments? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrickaw derrickaw derrickaw left review comments
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

addition New feature or request size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ihebimad @derrickaw