fix(Spanner): Fixed shard file config structure in reverse replication FT tests.#3933
fix(Spanner): Fixed shard file config structure in reverse replication FT tests.#3933pratickchokhani wants to merge 1 commit into
Conversation
pratickchokhani
added
bug
pratickchokhani
force-pushed
the
rr-shard-config-fix
branch
from
17f77bb to
5a75799
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
=============================================
+ Coverage 35.52% 55.66% +20.14%
- Complexity 697 6723 +6026
=============================================
Files 250 1114 +864
Lines 17031 68226 +51195
Branches 1721 7701 +5980
=============================================
+ Hits 6051 37981 +31930
- Misses 10474 27782 +17308
- Partials 506 2463 +1957
🚀 New features to boost your workflow:
|
pratickchokhani
force-pushed
the
rr-shard-config-fix
branch
from
5a75799 to
8fd85cb
Compare
pratickchokhani
requested review from
VardhanThigle,
aasthabharill and
darshan-sj
and removed request for
VardhanThigle
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Spanner-to-SourceDB reverse replication functional tests to align with the correct shard file configuration structure. By utilizing the 'JdbcShardConfig' class, the test suite now generates configuration files in a more robust and maintainable manner, eliminating manual JSON field removal and array construction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates SpannerToSourceDbFTBase.java to use JdbcShardConfig for structuring and serializing shard configurations to GCS, replacing the manual construction of a JsonArray of Shard objects. There are no review comments, so I have no feedback to provide.
| JsonArray ja = new JsonArray(); | ||
| ja.add(jsObj); | ||
| String shardFileContents = ja.toString(); | ||
| JdbcShardConfig jdbcShardConfig = new JdbcShardConfig(); |
There was a problem hiding this comment.
nit:check if there are more references to this block and extract a method.
Marking as LGTM as this is not a blocker.
2 participants
No description provided.