Skip to content

feat(yaml): Add Pub/Sub to Iceberg YAML template#4020

Merged
derrickaw merged 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/pubsub-to-iceberg
Jul 16, 2026
Merged

feat(yaml): Add Pub/Sub to Iceberg YAML template#4020
derrickaw merged 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/pubsub-to-iceberg

Conversation

@ihebimad

Copy link
Copy Markdown
Contributor

Successful job ID: 2026-07-13_01_45_58-10276467203691830168

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new YAML-based Dataflow template for streaming data from Google Cloud Pub/Sub to Apache Iceberg. It includes all required infrastructure, such as the template definition, documentation, and an integration test, to support this new pipeline capability.

Highlights

  • New YAML Template: Added a new Pub/Sub to Iceberg YAML template to enable streaming data ingestion from Pub/Sub to Apache Iceberg tables.
  • Configuration and Documentation: Included the necessary YAML configuration files, documentation, and Java interface definition for the new template.
  • Integration Testing: Added a new integration test class to verify the functionality of the Pub/Sub to Iceberg YAML template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Pub/Sub to Iceberg (YAML) template, including its documentation, Java interface definition, YAML template, and integration tests. The review feedback highlights syntax errors in the YAML template where Java array initializer syntax was incorrectly used for 'filesToCopy' and 'requirements' instead of standard YAML lists. Additionally, the reviewer recommends making the 'topic' and 'schema' parameters optional in the Java interface to support reading from subscriptions and handling RAW or STRING formats without requiring a schema.

Comment thread yaml/src/main/yaml/PubsubToIceberg.yaml
Comment thread yaml/src/main/yaml/PubsubToIceberg.yaml
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.09%. Comparing base (1608d1d) to head (fc15ef4).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1608d1d) and HEAD (fc15ef4). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (1608d1d) HEAD (fc15ef4)
6 1
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4020       +/-   ##
=============================================
- Coverage     55.70%   38.09%   -17.61%     
+ Complexity     7236      511     -6725     
=============================================
  Files          1124      195      -929     
  Lines         68447    11759    -56688     
  Branches       7721     1176     -6545     
=============================================
- Hits          38127     4480    -33647     
+ Misses        27846     6914    -20932     
+ Partials       2474      365     -2109     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 954 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added the addition New feature or request label Jul 16, 2026
@derrickaw
derrickaw merged commit f06772e into GoogleCloudPlatform:main Jul 16, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants