feat(yaml): Add Pub/Sub to Iceberg YAML template#4020
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new YAML-based Dataflow template for streaming data from Google Cloud Pub/Sub to Apache Iceberg. It includes all required infrastructure, such as the template definition, documentation, and an integration test, to support this new pipeline capability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Pub/Sub to Iceberg (YAML) template, including its documentation, Java interface definition, YAML template, and integration tests. The review feedback highlights syntax errors in the YAML template where Java array initializer syntax was incorrectly used for 'filesToCopy' and 'requirements' instead of standard YAML lists. Additionally, the reviewer recommends making the 'topic' and 'schema' parameters optional in the Java interface to support reading from subscriptions and handling RAW or STRING formats without requiring a schema.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
=============================================
- Coverage 55.70% 38.09% -17.61%
+ Complexity 7236 511 -6725
=============================================
Files 1124 195 -929
Lines 68447 11759 -56688
Branches 7721 1176 -6545
=============================================
- Hits 38127 4480 -33647
+ Misses 27846 6914 -20932
+ Partials 2474 365 -2109
🚀 New features to boost your workflow:
|
Successful job ID: 2026-07-13_01_45_58-10276467203691830168