try fixing missing delta lake read class#4038
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
============================================
+ Coverage 35.58% 38.09% +2.51%
+ Complexity 697 511 -186
============================================
Files 250 195 -55
Lines 17049 11759 -5290
Branches 1729 1176 -553
============================================
- Hits 6067 4480 -1587
+ Misses 10473 6914 -3559
+ Partials 509 365 -144
🚀 New features to boost your workflow:
|
derrickaw
changed the title
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the Delta Lake read transform to rearrange based on discovery and adds temporary test dependencies in yaml/pom.xml. It also introduces a local test loopback option in the test suite. The feedback highlights a PEP 8 violation in read_from_delta_lake_test.py where executable code is placed between import statements, which should be moved below all imports.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a runtime error occurring in the Build and Upload Python Package workflow, where the system failed to locate the required SchemaTransformProvider for Delta Lake reads. By enabling discovery-based rearrangement and explicitly including the missing Java dependencies in the test configuration, the build process is now able to correctly resolve and utilize the Delta Lake IO components. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request configures "rearrange_based_on_discovery=True" for Delta Lake reads, updates the corresponding unit tests, and adds temporary test dependencies in "yaml/pom.xml" for "beam-sdks-java-expansion-service", "beam-sdks-java-io-delta", and "jamm". The feedback points out a typo in the version number ("2.76.0" instead of "2.56.0") within the TODO comment in "yaml/pom.xml" and suggests correcting it to ensure proper cleanup.
|
R: @chamikaramj, when running the workflow, it failed with the desc above. Added a java build step as a temp workaround. Is this the best way to do this or is there a better way? Thanks |
|
The error indicates that the expansion service was started (through |
|
We probably need to build a expansion-service jar that include relavent changes to https://github.com/apache/beam/blob/master/sdks/java/io/expansion-service/build.gradle (one line on top of 2.75.0) and also host that for this to work. |
2 participants
java.lang.RuntimeException: Did not find a SchemaTransformProvider with the identifier beam:schematransform:org.apache.beam:delta_lake_read:v1