Skip to content

Commit 3a4a62d

Browse files
Fix issues with CookieCompliance on Jetty 9.4 HttpConnector mode.
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
1 parent f71ace0 commit 3a4a62d

2 files changed

Lines changed: 7 additions & 28 deletions

File tree

runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/CookieComplianceTest.java

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import static com.google.common.truth.Truth.assertThat;
2020
import static org.junit.Assume.assumeTrue;
2121

22-
import java.util.Arrays;
2322
import java.util.List;
2423
import org.apache.http.Header;
2524
import org.apache.http.HttpResponse;
@@ -36,34 +35,14 @@
3635
@RunWith(Parameterized.class)
3736
public class CookieComplianceTest extends JavaRuntimeViaHttpBase {
3837

39-
// This is set in the app appengine-web.xml file
38+
// This is set in the app appengine-web.xml file.
4039
static {
4140
System.setProperty("com.google.apphosting.runtime.jetty94.LEGACY_MODE", "true");
4241
}
4342

4443
@Parameterized.Parameters
4544
public static List<Object[]> version() {
46-
return Arrays.asList(
47-
new Object[][] {
48-
{"java17", "9.4", "EE6", false},
49-
{"java17", "12.0", "EE8", false},
50-
{"java17", "12.0", "EE10", false},
51-
{"java17", "12.1", "EE11", false},
52-
{"java21", "12.0", "EE8", false},
53-
{"java21", "12.0", "EE10", false},
54-
{"java21", "12.1", "EE11", false},
55-
{"java25", "12.1", "EE8", false},
56-
{"java25", "12.1", "EE11", false},
57-
{"java17", "9.4", "EE6", true},
58-
{"java17", "12.0", "EE8", true},
59-
{"java17", "12.0", "EE10", true},
60-
{"java17", "12.1", "EE11", true},
61-
{"java21", "12.0", "EE8", true},
62-
{"java21", "12.0", "EE10", true},
63-
{"java21", "12.1", "EE11", true},
64-
{"java25", "12.1", "EE8", true},
65-
{"java25", "12.1", "EE11", true},
66-
});
45+
return allVersions();
6746
}
6847

6948
public CookieComplianceTest(String runtimeVersion, String jettyVersion, String version, boolean useHttpConnector) {

runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/JavaRuntimeViaHttpBase.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
import static java.util.concurrent.TimeUnit.SECONDS;
3232
import static org.awaitility.Awaitility.await;
3333

34+
import com.google.appengine.repackaged.com.google.protobuf.ByteString;
35+
import com.google.appengine.repackaged.com.google.protobuf.ExtensionRegistry;
36+
import com.google.appengine.repackaged.com.google.protobuf.InvalidProtocolBufferException;
37+
import com.google.appengine.repackaged.com.google.protobuf.UninitializedMessageException;
3438
import com.google.apphosting.base.protos.api.RemoteApiPb;
3539
import com.google.apphosting.testing.PortPicker;
3640
import com.google.auto.value.AutoValue;
@@ -45,10 +49,6 @@
4549
import com.google.common.reflect.Reflection;
4650
import com.google.errorprone.annotations.CanIgnoreReturnValue;
4751
import com.google.errorprone.annotations.ForOverride;
48-
import com.google.appengine.repackaged.com.google.protobuf.ByteString;
49-
import com.google.appengine.repackaged.com.google.protobuf.ExtensionRegistry;
50-
import com.google.appengine.repackaged.com.google.protobuf.InvalidProtocolBufferException;
51-
import com.google.appengine.repackaged.com.google.protobuf.UninitializedMessageException;
5252
import com.sun.net.httpserver.HttpExchange;
5353
import com.sun.net.httpserver.HttpServer;
5454
import java.io.BufferedReader;
@@ -171,7 +171,7 @@ public static List<Object[]> allVersions() {
171171
System.out.println("javaVersionForTest " + javaVersionForTest);
172172

173173
return allVersions.stream()
174-
.filter(v -> v[0].toString().equals(javaVersionForTest))
174+
.filter(v -> v[0].toString().equals(javaVersionForTest) || v[1].equals("9.4"))
175175
.collect(toImmutableList());
176176
}
177177

0 commit comments

Comments
 (0)