Skip to content

Commit cdd5e6a

Browse files
ludochgae-java-bot
authored andcommitted
The Protobuf compiler version is now managed via a property. The protoc-jar-maven-plugin configuration was updated to use the protoc artifact and its execution phase was moved to the parent pom. The unused protobuf/bridge/message_set.proto file has been removed.
PiperOrigin-RevId: 843685877 Change-Id: I80bd1f594d8cfdadb618183ebc58c07e468450fa
1 parent 0811ccf commit cdd5e6a

8 files changed

Lines changed: 11 additions & 104 deletions

File tree

pom.xml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
<jetty12.version>12.0.31</jetty12.version>
7878
<jetty121.version>12.1.5</jetty121.version>
7979
<slf4j.version>2.0.17</slf4j.version>
80+
<protoc.version>3.21.12</protoc.version>
8081
<distributionManagement.snapshot.url>https://oss.sonatype.org/content/repositories/google-snapshots/</distributionManagement.snapshot.url>
8182
<distributionManagement.snapshot.id>sonatype-nexus-snapshots</distributionManagement.snapshot.id>
8283
<distributionManagement.release.url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</distributionManagement.release.url>
@@ -521,12 +522,7 @@
521522
<dependency>
522523
<groupId>com.google.protobuf</groupId>
523524
<artifactId>protobuf-java</artifactId>
524-
<version>3.21.12</version> <!-- keep -->
525-
</dependency>
526-
<dependency>
527-
<groupId>com.google.protobuf</groupId>
528-
<artifactId>protobuf-java-util</artifactId>
529-
<version>3.21.12</version> <!-- keep -->
525+
<version>${protoc.version}</version>
530526
</dependency>
531527
<dependency>
532528
<groupId>javax.activation</groupId>
@@ -835,12 +831,16 @@
835831
<groupId>com.github.os72</groupId>
836832
<artifactId>protoc-jar-maven-plugin</artifactId>
837833
<version>3.11.4</version>
834+
<executions>
835+
<execution>
836+
<phase>generate-sources</phase>
837+
<goals>
838+
<goal>run</goal>
839+
</goals>
840+
</execution>
841+
</executions>
838842
<configuration>
839-
<!-- Try to keep this protoc compiler version up to date with:
840-
https://github.com/protocolbuffers/protobuf/blob/master/java/pom.xml#L7
841-
Read https://github.com/os72/protoc-jar-maven-plugin/issues/107 for context.
842-
-->
843-
<protocVersion>3.21.12</protocVersion>
843+
<protocArtifact>com.google.protobuf:protoc:${protoc.version}</protocArtifact>
844844
</configuration>
845845
</plugin>
846846
<plugin>

protobuf/bridge/message_set.proto

Lines changed: 0 additions & 59 deletions
This file was deleted.

protobuf/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,21 +43,12 @@
4343
<plugin>
4444
<groupId>com.github.os72</groupId>
4545
<artifactId>protoc-jar-maven-plugin</artifactId>
46-
<executions>
47-
<execution>
48-
<phase>generate-sources</phase>
49-
<goals>
50-
<goal>run</goal>
51-
</goals>
52-
</execution>
53-
</executions>
5446
<configuration>
5547
<inputDirectories>
5648
<dir>.</dir>
5749
</inputDirectories>
5850
<includeDirectories>
5951
<dir>./api</dir>
60-
<dir>./bridge</dir>
6152
</includeDirectories>
6253
</configuration>
6354
</plugin>

renovate.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
"org.mortbay.jasper:apache-jsp",
1717
"org.apache.lucene:lucene-core",
1818
"com.google.protobuf:protobuf-java",
19-
"com.google.protobuf:protobuf-java-util",
2019
"com.google.api.grpc:proto-google-common-protos",
2120
"com.google.api.grpc:proto-google-cloud-datastore-v1",
2221
"com.google.cloud.datastore:datastore-v1-proto-client",

runtime/impl/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,6 @@
9999
<artifactId>protobuf-java</artifactId>
100100
<optional>true</optional>
101101
</dependency>
102-
<dependency>
103-
<groupId>com.google.protobuf</groupId>
104-
<artifactId>protobuf-java-util</artifactId>
105-
<optional>true</optional>
106-
</dependency>
107-
108102
<dependency>
109103
<groupId>javax.servlet</groupId>
110104
<artifactId>javax.servlet-api</artifactId>

runtime/runtime_impl_jetty12/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,6 @@
111111
<artifactId>protobuf-java</artifactId>
112112
<optional>true</optional>
113113
</dependency>
114-
<dependency>
115-
<groupId>com.google.protobuf</groupId>
116-
<artifactId>protobuf-java-util</artifactId>
117-
<optional>true</optional>
118-
</dependency>
119114
<dependency>
120115
<groupId>org.eclipse.jetty</groupId>
121116
<artifactId>jetty-client</artifactId>
@@ -477,7 +472,6 @@
477472
<include>com.google.guava:listenablefuture</include>
478473
<include>com.google.j2objc:j2objc-annotations</include>
479474
<include>com.google.protobuf:protobuf-java</include>
480-
<include>com.google.protobuf:protobuf-java-util</include>
481475
<include>commons-codec:commons-codec</include>
482476
<include>io.perfmark:perfmark-api</include>
483477
<include>javax.annotation:javax.annotation-api</include>

runtime/runtime_impl_jetty121/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,6 @@
111111
<artifactId>protobuf-java</artifactId>
112112
<optional>true</optional>
113113
</dependency>
114-
<dependency>
115-
<groupId>com.google.protobuf</groupId>
116-
<artifactId>protobuf-java-util</artifactId>
117-
<optional>true</optional>
118-
</dependency>
119114
<dependency>
120115
<groupId>org.eclipse.jetty</groupId>
121116
<artifactId>jetty-client</artifactId>
@@ -500,7 +495,6 @@
500495
<include>com.google.guava:listenablefuture</include>
501496
<include>com.google.j2objc:j2objc-annotations</include>
502497
<include>com.google.protobuf:protobuf-java</include>
503-
<include>com.google.protobuf:protobuf-java-util</include>
504498
<include>commons-codec:commons-codec</include>
505499
<include>io.perfmark:perfmark-api</include>
506500
<include>javax.annotation:javax.annotation-api</include>

runtime/runtime_impl_jetty9/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,6 @@
106106
<artifactId>protobuf-java</artifactId>
107107
<optional>true</optional>
108108
</dependency>
109-
<dependency>
110-
<groupId>com.google.protobuf</groupId>
111-
<artifactId>protobuf-java-util</artifactId>
112-
<optional>true</optional>
113-
</dependency>
114109
<dependency>
115110
<groupId>org.eclipse.jetty</groupId>
116111
<artifactId>jetty-client</artifactId>
@@ -372,7 +367,6 @@
372367
<include>com.google.guava:listenablefuture</include>
373368
<include>com.google.j2objc:j2objc-annotations</include>
374369
<include>com.google.protobuf:protobuf-java</include>
375-
<include>com.google.protobuf:protobuf-java-util</include>
376370
<include>commons-codec:commons-codec</include>
377371
<include>io.perfmark:perfmark-api</include>
378372
<include>javax.annotation:javax.annotation-api</include>

0 commit comments

Comments
 (0)